Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support creating custom spans and attributes in the startup trace #1824

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Jan 16, 2025

Goal

Add the ability to add custom child spans and attributes to UI load traces. Also exposed a public method to get the SDK timestamp so the custom spans can use the same clock as the rest of the spans i the traces

Testing

Added unit and integration tests

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.49%. Comparing base (f5d05e1) to head (db83123).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...nternal/api/delegate/InstrumentationApiDelegate.kt 50.00% 1 Missing and 4 partials ⚠️
...main/java/io/embrace/android/embracesdk/Embrace.kt 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1824      +/-   ##
==========================================
+ Coverage   85.38%   85.49%   +0.11%     
==========================================
  Files         473      473              
  Lines       11015    11048      +33     
  Branches     1648     1652       +4     
==========================================
+ Hits         9405     9446      +41     
+ Misses        877      867      -10     
- Partials      733      735       +2     
Files with missing lines Coverage Δ
...roid/embracesdk/internal/api/InstrumentationApi.kt 100.00% <100.00%> (ø)
...nternal/capture/startup/AppStartupDataCollector.kt 80.00% <ø> (ø)
...internal/capture/startup/AppStartupTraceEmitter.kt 80.39% <100.00%> (+7.29%) ⬆️
...main/java/io/embrace/android/embracesdk/Embrace.kt 86.86% <88.88%> (+0.20%) ⬆️
...nternal/api/delegate/InstrumentationApiDelegate.kt 62.06% <50.00%> (-6.36%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator Author

bidetofevil commented Jan 17, 2025

Merge activity

  • Jan 17, 12:36 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 17, 12:39 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 17, 12:51 PM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil changed the base branch from hho/swazzled-hooks to graphite-base/1824 January 17, 2025 17:37
@bidetofevil bidetofevil changed the base branch from graphite-base/1824 to main January 17, 2025 17:37
@bidetofevil bidetofevil force-pushed the hho/custom-startup-trace branch from cdbca55 to db83123 Compare January 17, 2025 17:38
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@bidetofevil bidetofevil merged commit 58bbf3e into main Jan 17, 2025
5 of 6 checks passed
@bidetofevil bidetofevil deleted the hho/custom-startup-trace branch January 17, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants