Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename instrumentation API #1826

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Rename instrumentation API #1826

merged 1 commit into from
Jan 17, 2025

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Jan 16, 2025

Goal

Give better names to the public instrumentation customization APIs

@bidetofevil bidetofevil force-pushed the hho/consolidate-sdk-time-api branch from 4de9a79 to f5df002 Compare January 17, 2025 06:58
@bidetofevil bidetofevil force-pushed the hho/instrumentation-api branch 2 times, most recently from d3b888b to 55f5734 Compare January 17, 2025 07:12
@bidetofevil bidetofevil marked this pull request as ready for review January 17, 2025 07:16
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.50%. Comparing base (4eeb616) to head (15460dc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...nternal/api/delegate/InstrumentationApiDelegate.kt 0.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1826   +/-   ##
=======================================
  Coverage   85.50%   85.50%           
=======================================
  Files         473      473           
  Lines       11046    11046           
  Branches     1652     1652           
=======================================
  Hits         9445     9445           
  Misses        865      865           
  Partials      736      736           
Files with missing lines Coverage Δ
...roid/embracesdk/internal/api/InstrumentationApi.kt 100.00% <100.00%> (ø)
...main/java/io/embrace/android/embracesdk/Embrace.kt 87.87% <100.00%> (ø)
...nternal/api/delegate/InstrumentationApiDelegate.kt 65.51% <0.00%> (ø)

Copy link
Collaborator Author

bidetofevil commented Jan 17, 2025

Merge activity

  • Jan 17, 12:36 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 17, 1:07 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 17, 1:18 PM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil changed the base branch from hho/consolidate-sdk-time-api to graphite-base/1826 January 17, 2025 17:52
@bidetofevil bidetofevil changed the base branch from graphite-base/1826 to main January 17, 2025 18:05
@bidetofevil bidetofevil force-pushed the hho/instrumentation-api branch from 55f5734 to 15460dc Compare January 17, 2025 18:06
Copy link
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@bidetofevil bidetofevil merged commit 11681a0 into main Jan 17, 2025
5 of 6 checks passed
@bidetofevil bidetofevil deleted the hho/instrumentation-api branch January 17, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants