Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate and disambiguate version checking for load traces capability detection #1833

Merged
merged 1 commit into from
Jan 22, 2025

Consolidate and disambiguate version checking for load traces capabil…

fc6d9ef
Select commit
Loading
Failed to load commit list.
Merged

Consolidate and disambiguate version checking for load traces capability detection #1833

Consolidate and disambiguate version checking for load traces capabil…
fc6d9ef
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 21, 2025 in 0s

85.51% (-0.01%) compared to a5e334e

View this Pull Request on Codecov

85.51% (-0.01%) compared to a5e334e

Details

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.51%. Comparing base (a5e334e) to head (fc6d9ef).

Files with missing lines Patch % Lines
...internal/injection/DataCaptureServiceModuleImpl.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1833      +/-   ##
==========================================
- Coverage   85.52%   85.51%   -0.01%     
==========================================
  Files         473      473              
  Lines       11068    11069       +1     
  Branches     1653     1654       +1     
==========================================
  Hits         9466     9466              
  Misses        866      866              
- Partials      736      737       +1     
Files with missing lines Coverage Δ
.../embracesdk/internal/capture/activity/UiLoadExt.kt 98.86% <100.00%> (+0.02%) ⬆️
...dk/internal/capture/activity/UiLoadTraceEmitter.kt 93.07% <100.00%> (-0.06%) ⬇️
...internal/capture/startup/AppStartupTraceEmitter.kt 82.02% <100.00%> (+0.08%) ⬆️
...internal/injection/DataCaptureServiceModuleImpl.kt 94.00% <83.33%> (-2.08%) ⬇️