Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate and disambiguate version checking for load traces capability detection #1833

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

bidetofevil
Copy link
Collaborator

@bidetofevil bidetofevil commented Jan 21, 2025

Goal

Split up and consolidate the logic to check whether the current API version fires pre and post lifecycle events and whether or not we we try to instrument rendering for UI Load events.

This is so that in a later PR, we can disable the rendering events without affecting everything else.

Testing

Existing tests pass

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.51%. Comparing base (a5e334e) to head (fc6d9ef).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...internal/injection/DataCaptureServiceModuleImpl.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1833      +/-   ##
==========================================
- Coverage   85.52%   85.51%   -0.01%     
==========================================
  Files         473      473              
  Lines       11068    11069       +1     
  Branches     1653     1654       +1     
==========================================
  Hits         9466     9466              
  Misses        866      866              
- Partials      736      737       +1     
Files with missing lines Coverage Δ
.../embracesdk/internal/capture/activity/UiLoadExt.kt 98.86% <100.00%> (+0.02%) ⬆️
...dk/internal/capture/activity/UiLoadTraceEmitter.kt 93.07% <100.00%> (-0.06%) ⬇️
...internal/capture/startup/AppStartupTraceEmitter.kt 82.02% <100.00%> (+0.08%) ⬆️
...internal/injection/DataCaptureServiceModuleImpl.kt 94.00% <83.33%> (-2.08%) ⬇️

@bidetofevil bidetofevil marked this pull request as ready for review January 21, 2025 21:41
@bidetofevil bidetofevil requested a review from a team as a code owner January 21, 2025 21:41
Copy link
Collaborator Author

bidetofevil commented Jan 22, 2025

Merge activity

  • Jan 22, 4:04 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 22, 4:04 PM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil merged commit c296d8d into main Jan 22, 2025
8 checks passed
@bidetofevil bidetofevil deleted the hho/ui-api-check branch January 22, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants