Disable the use of render events to construct UI load traces for now #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
bidetofevil
force-pushed
the
hho/ui-api-check
branch
from
9424bbd to
fc6d9ef
Compare
bidetofevil
force-pushed
the
hho/disable-render-event
branch
from
a6c6d47 to
4eb3c18
Compare
bidetofevil
requested review from
fractalwrench
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1834 +/- ##
==========================================
- Coverage 85.53% 85.25% -0.29%
==========================================
Files 473 473
Lines 11069 11069
Branches 1654 1654
==========================================
- Hits 9468 9437 -31
- Misses 865 894 +29
- Partials 736 738 +2
|
fractalwrench
approved these changes
Jan 22, 2025
bidetofevil
changed the base branch from
hho/ui-api-check
to
graphite-base/1834
bidetofevil
force-pushed
the
hho/disable-render-event
branch
from
4eb3c18 to
20bc609
Compare
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Disable rendering event usage in UI load traces for now, as the way it detects the first frame draw is on the Window's root view, which isn't compatible with Compose navigation.
This means that for now, all versions of Android will end with the onResume event.
Testing
Existing tests pass after adjustments