[AUDIO_WORKLET] Fix spinlocks for audio worklets (and add tests) #22995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Nov 24, 2024
cwoffenden
force-pushed
the
cw-audio-tweaks-4
branch
2 times, most recently
from
b70f88c to
81bcaa2
Compare
cwoffenden
force-pushed
the
cw-audio-tweaks-4
branch
8 times, most recently
from
cf23f0e to
aa78b84
Compare
cwoffenden
force-pushed
the
cw-audio-tweaks-4
branch
3 times, most recently
from
cbd6be7 to
2dcfb14
Compare
|
@sbc100 this looks like it's good to go? |
sbc100
reviewed
Jan 2, 2025
Sure this change LGTM if we split out or remove the API change (which makes this a test-only change). Just to be clear when you say "fixed something broken" you mean the it fixes the testing.. not an actual fix in emscripten itself? Or am I missunderstanding? |
cwoffenden
force-pushed
the
cw-audio-tweaks-4
branch
from
2dcfb14 to
27cf421
Compare
cwoffenden
changed the title
cwoffenden
force-pushed
the
cw-audio-tweaks-4
branch
from
27cf421 to
5ac384b
Compare
|
Closed to recreate a new PR (since it had too many changes to keep track and undo, and GitHub closed it for me once I reset Git to the start of the changes). New PR in #23729. |
sbc100
pushed a commit
that referenced
this pull request
Feb 25, 2025
…#23729) - spinlocks fixed so they work in audio worklets - adds tests for various spinlock cases - test converted to C-only (still in a C++ file for now, see below) This was unmerged last year (#22995), visited again now the browser tests are running with audio. It's been moved over to `btest_exit()` and verified that it runs (and will only exit after all tests have run or asserted). The only change I'd make is to rename the original test file, which has grown beyond its original use. A `git mv` command won't survive multiple commits, so I want to either leave it until last, live with the resulting deletion, or rename as a separate PR. Fixes: #22962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #22962 and adds tests:
test for atomic wait exposed as a public function(The
git mvlost the old to new mapping at some point)