[AUDIO_WORKLET] Enable AW spinlocks, verify them in the browser tests #23729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwoffenden
changed the title
cwoffenden
force-pushed
the
cw-audio-spinlock-refix
branch
from
0b71d81 to
af3d551
Compare
sbc100
approved these changes
Feb 24, 2025
sbc100
reviewed
Feb 24, 2025
test/test_browser.py
Outdated
| def test_audio_worklet_emscripten_futex_wake(self): | ||
| self.btest('webaudio/audioworklet_emscripten_futex_wake.cpp', expected='0', args=['-sAUDIO_WORKLET', '-sWASM_WORKERS', '-pthread', '-sPTHREAD_POOL_SIZE=2']) | ||
| def test_audio_worklet_emscripten_locks(self): | ||
| self.btest_exit('webaudio/audioworklet_emscripten_futex_wake.cpp', args=['-sAUDIO_WORKLET', '-sWASM_WORKERS', '-pthread', '-sPTHREAD_POOL_SIZE=2']) |
There was a problem hiding this comment.
Does this test actually start any pthreads? I.e. can we remove -sPTHREAD_POOL_SIZE?
There was a problem hiding this comment.
I’ll take a look tomorrow, I kept this from the original interactive test.
There was a problem hiding this comment.
We can remove -sPTHREAD_POOL_SIZE but not -pthread (otherwise _emscripten_thread_supports_atomics_wait won't link).
Done, and also rebased to bring in the Firefox CI changes.
cwoffenden
force-pushed
the
cw-audio-spinlock-refix
branch
from
a0ca317 to
eed0ca2
Compare
kripken
pushed a commit
that referenced
this pull request
Feb 27, 2025
Performed as a separate step from #23729 to not lose the history. The C++ file had already been converted to C as part of the previous PR, this now updates the filename and its extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was unmerged last year (#22995), visited again now the browser tests are running with audio. It's been moved over to
btest_exit()and verified that it runs (and will only exit after all tests have run or asserted).The only change I'd make is to rename the original test file, which has grown beyond its original use. A
git mvcommand won't survive multiple commits, so I want to either leave it until last, live with the resulting deletion, or rename as a separate PR.Fixes: #22962