Remove redundant check for SUPPORT_BASE64_EMBEDDING in getWasmBinary. NFC #23491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_redundant_check
branch
from
531301c to
8746018
Compare
… NFC This block of code is withing `!SINGLE_FILE` but `SUPPORT_BASE64_EMBEDDING` is only ever defined when `SINGLE_FILE` is enabled. In the past I think `SUPPORT_BASE64_EMBEDDING` may have been defined under more circumstances? No codesize changes here because this code was never actually emitted.
sbc100
force-pushed
the
remove_redundant_check
branch
from
8746018 to
0f280b3
Compare
kripken
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This block of code is withing
!SINGLE_FILEbutSUPPORT_BASE64_EMBEDDINGis only ever defined whenSINGLE_FILEis enabled.In the past I think
SUPPORT_BASE64_EMBEDDINGmay have been defined under more circumstances?The codesize changes are just white-space only changes in the un-optimized output.