Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant check for SUPPORT_BASE64_EMBEDDING in getWasmBinary. NFC #23491

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Remove redundant check for SUPPORT_BASE64_EMBEDDING in getWasmBinary. NFC #23491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/preamble.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,11 +627,7 @@ function getBinarySync(file) {
async function getWasmBinary(binaryFile) {
#if !SINGLE_FILE
// If we don't have the binary yet, load it asynchronously using readAsync.
if (!wasmBinary
#if SUPPORT_BASE64_EMBEDDING
|| isDataURI(binaryFile)
#endif
) {
if (!wasmBinary) {
// Fetch the binary using readAsync
try {
var response = await readAsync(binaryFile);
Expand Down
2 changes: 1 addition & 1 deletion test/other/test_unoptimized_code_size.js.size
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
52739
52732
2 changes: 1 addition & 1 deletion test/other/test_unoptimized_code_size_no_asserts.js.size
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
28487
28480
2 changes: 1 addition & 1 deletion test/other/test_unoptimized_code_size_strict.js.size
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
51522
51515
Loading