You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Details
For some reason most error messages were not displaying for me. Perhaps missing some latest changes. I have left my suggestions below. In each case I have throttling turned off while navigating to the appropriate view, then set my browser network settings to offline.
Tasks
When updating the Board Configurations while offline, I am getting the following error (shown below). Could we simplify this message for the user (to also be consistent with Ammar's previous Add Post error message): "Unable to update board configurations. Please refresh and try again!"
For the board configurations, if I turn the browser offline either before I open the project modal or after I open the project modal then press the Update button, the button either spins and closes (without an error message) or spins indefinitely (without an error message). Can we ensure the following message is being displayed: "Unable to update board configurations. Please refresh and try again!"
On the Add Post modal, I am able to add a tag to the post and there is no error. Can we (1) have the tag fail to be visually added to the post (as with the View Post modal) and (2) ensure the following error message is displayed when the user clicks to add a tag: "Unable to add tag. Please refresh and try again!"
When the tag fails to be added in the View Post modal, can we display the error message: "Unable to add tag. Please refresh and try again!"
When editing the title or the message of a post, when the Update button is pressed after editing the title or message, can we display an error message: "Unable to update post. Please refresh and try again!"
@DCH25 Perhaps we've been using different means of simulating latency or network issues. Please let me know if you have any questions or would like to discuss anything!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Closes #513