Skip to content

feat: [513] added loading state to async buttons #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DCH25 wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: [513] added loading state to async buttons #526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46aeb82
feat: [513] added loading state to async button
DCH25 Apr 12, 2023
7ce54d0
feat: project configuration spinners
DCH25 Apr 12, 2023
e10558f
feat: post modal loading spinners
DCH25 Apr 12, 2023
2cd5e39
fix: snackbar fades after 5 seconds
DCH25 Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/api/boards.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ router.post('/:boardID/copy-configuration', async (req, res) => {
);

await dalBoard.updateMany(boards, updatedBoard);
res.status(200);
res.status(200).json(boards);
});

router.get('/:id', async (req, res) => {
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/app/components/add-post-modal/add-post.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ <h1 mat-dialog-title *ngIf="editingPost">Update Post</h1>
<mat-icon class="cancel" (click)="removeTag(tag)">cancel</mat-icon>
</mat-chip>
<mat-menu #menu1="matMenu">
<div mat-menu-item *ngIf="tagOptions && tagOptions.length == 0">
<div mat-menu-item *ngIf="tagOptions && tagOptions.length === 0">
No tags available.
</div>
<div
Expand Down
6 changes: 4 additions & 2 deletions frontend/src/app/components/configuration-modal/configuration-modal.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,8 @@ <h2>UI Elements</h2>
</mat-form-field>
<button
mat-button
[disabled]="newTagText.length < 1"
[class.spinner]="loading"
[disabled]="newTagText.length < 1 || loading"
color="primary"
(click)="addTag()"
>
Expand All @@ -261,10 +262,11 @@ <h2>UI Elements</h2>
<button
mat-button
(click)="handleDialogSubmit()"
[class.spinner]="loading"
[disabled]="
(taskMessage && !taskTitle.trim()) ||
(taskTitle && !taskTitle.trim()) ||
boardNameInput.invalid
boardNameInput.invalid || loading
"
cdkFocusInitial
>
Expand Down
Loading