feat: add txn id on nexo transactions#203
Open
iloveitaly wants to merge 2 commits into
Open
Conversation
eprbell
requested changes
Sep 17, 2023
eprbell
left a comment
eprbell
left a comment
Owner
There was a problem hiding this comment.
Minor comment. Also please rebase your code to get past the documentation error.
iloveitaly
force-pushed
the
transaction-id-on-nexo
branch
from
October 15, 2023 10:47
41e28a1 to
2375b45
Compare
Contributor
Author
|
@eprbell done! |
Collaborator
|
@iloveitaly just a heads up. The failing tests are caused by a change in the fiat pricing API we use. A PR has already been opened to address it #212 |
Collaborator
|
@iloveitaly @eprbell The tests on this pass now with the updated fiat gateway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.