Implement Access Keys for Exchangerates.host#212
Conversation
61cab14 to
2b0ff4e
Compare
828c379 to
4392e35
Compare
4392e35 to
6de332a
Compare
|
@eprbell It took some finagling, but I got vcrpy to work. It does not really like Python < 3.10. The package itself is amazing. It really speeds things up and is easy to use. It cuts down on a lot of bulky mocking code. |
eprbell
left a comment
eprbell
left a comment
There was a problem hiding this comment.
Great! I have just a few nits here and there but otherwise it LGTM.
eprbell
left a comment
eprbell
left a comment
There was a problem hiding this comment.
A few comments here and there: getting there!
|
@eprbell Sorry about the confusion. I should have made a comment instead of pushed the request review button. I've been snowed over with this new job at times. I was in a rush. Hopefully, this is all good to go now. Let me know if you need anything else. After this gets rolled through, I'll try to rebase the pricing correction #207 and then if we rebase #203 it should also go green. |
eprbell
left a comment
eprbell
left a comment
There was a problem hiding this comment.
LGTM! No worries, I know what it's like to start a new coding job (I hope that it's going well though). Thanks for fixing this!
2 participants
This PR will significantly speed up testing and make them more performant. It adds Vcrpy to Dali-RP2, so that we can mock HTTP requests as well as adds support for the now necessary access keys for the fiat pricing provider Exchangerates.host.
Fixes #211