Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang toolchain to 1.23.5 #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajaysundark
Copy link

@ajaysundark ajaysundark commented Jan 17, 2025

etcd-operator: update golang toolchain to 1.23.5

Subtask from Issue: etcd-io/etcd#19210

  1. Retrieve golang:1.23.5-bookworm digest from docker hub (use the list-manifest for make to work would work with multi-arch):
TOKEN=$(curl -s "https://auth.docker.io/token?service=registry.docker.io&scope=repository:library/golang:pull" | jq -r .token)
curl -s -I -H "Authorization: Bearer $TOKEN" -H "Accept: application/vnd.docker.distribution.manifest.list.v2+json" "https://registry.hub.docker.com/v2/library/golang/manifests/1.23.5-bookworm" | grep -i "Docker-Content-Digest"
  1. Verify able to build and run unit-tests as -
make build
make docker-build
make test

@k8s-ci-robot
Copy link

Hi @ajaysundark. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Jan 17, 2025

/ok-to-test

@hakman
Copy link
Contributor

hakman commented Jan 17, 2025

@ajaysundark Please check all places where go 1.23.4 is referenced and update those too. Thanks!

@ajaysundark ajaysundark force-pushed the bump-etcdoperator-golang-toolchain-1.23.5 branch from 2e06d2d to 62a2a33 Compare January 17, 2025 23:51
@ajaysundark
Copy link
Author

@ajaysundark Please check all places where go 1.23.4 is referenced and update those too. Thanks!

Thanks for the call out. Also updated the golang image in dockerfile.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ajaysundark

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants