-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update golang toolchain to 1.23.5 #19214
Update golang toolchain to 1.23.5 #19214
Conversation
Hi @ajaysundark. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #19214 +/- ##
==========================================
+ Coverage 68.76% 68.79% +0.03%
==========================================
Files 420 420
Lines 35650 35650
==========================================
+ Hits 24513 24524 +11
+ Misses 9714 9701 -13
- Partials 1423 1425 +2 Continue to review full report in Codecov by Sentry.
|
/retest |
@ajaysundark could you please rebase this PR? |
Sounds good. I'll update it shortly.
…On Fri, Jan 17, 2025, 11:31 AM Benjamin Wang ***@***.***> wrote:
@ajaysundark <https://github.com/ajaysundark> could you please rebase
this PR?
—
Reply to this email directly, view it on GitHub
<#19214 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMFVBEI6A3GBY7US73BFA32LFLBXAVCNFSM6AAAAABVLJTUKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJZGA2TMMRYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Signed-off-by: ajaysundar.k <[email protected]>
17bc13e
to
74ffe2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @ajaysundark.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ajaysundark, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updates golang toolchain to 1.23.5
Subtask from Issue: #19210
Verified able to build and run unit-tests as -