Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang toolchain to 1.23.5 #19214

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

ajaysundark
Copy link
Contributor

Updates golang toolchain to 1.23.5

Subtask from Issue: #19210

Verified able to build and run unit-tests as -

make build-all
make test-unit

@k8s-ci-robot
Copy link

Hi @ajaysundark. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Jan 17, 2025

/ok-to-test

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (ecd7cfc) to head (74ffe2e).
Report is 2 commits behind head on main.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19214      +/-   ##
==========================================
+ Coverage   68.76%   68.79%   +0.03%     
==========================================
  Files         420      420              
  Lines       35650    35650              
==========================================
+ Hits        24513    24524      +11     
+ Misses       9714     9701      -13     
- Partials     1423     1425       +2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecd7cfc...74ffe2e. Read the comment docs.

@serathius
Copy link
Member

/retest

@ahrtr
Copy link
Member

ahrtr commented Jan 17, 2025

@ajaysundark could you please rebase this PR?

@ajaysundark
Copy link
Contributor Author

ajaysundark commented Jan 17, 2025 via email

@ajaysundark ajaysundark force-pushed the bump-etcd-golang-toolchain-1.23.5 branch from 17bc13e to 74ffe2e Compare January 18, 2025 00:09
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ajaysundark.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ajaysundark, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 6187c95 into etcd-io:main Jan 18, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants