Repository navigation
fix(core): stop masking pnpm store paths as email addresses - #817
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Thank you for following the naming conventions! 🙏 |
@evlog/cli
evlog
@evlog/nuxthub
@evlog/signals
@evlog/telemetry
commit: |
This was referenced Oct 10, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #813. Linear: EVL-533.
What changed
The built-in
emailpattern accepted digits and dots in the top-level domain, soname@versionsegments in pnpm store paths matched as addresses. Stack traces lost the package name and version. The pattern now requires a letters-only TLD of two or more characters. Subdomains still match, and real addresses are masked as before.Before / after
Real
redactEventoutput with built-inemailredaction:Verification
test(core): ...). It failed onmainwith the masked output above, and passes with the fix.pnpm run lint,pnpm run typecheck,pnpm run test: all exit 0 in the sandbox (evlog: 100 files, 2038 tests passed). Cold checks, read-only Turbo remote cache.pnpm test:coverageandpnpm api:snapshot(no public export changed).Known edge
An internationalized TLD such as
xn--p1aiis not matched in full. Its local part is still masked, but the domain tail stays visible. Real addresses with IDN domains are rare, and the previous pattern did not handle them correctly either.Changeset
patchforevlog.ELI5
The email hider was mistaking version numbers in file paths for email addresses, so error reports lost part of the path. The fix only treats something as an email when the ending looks like a real domain ending such as
.com. Real email addresses are hidden as before.