Skip to content

fix(core): stop masking pnpm store paths as email addresses #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HugoRCD merged 2 commits into from
Oct 10, 2026
Merged

fix(core): stop masking pnpm store paths as email addresses #817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
887f0ac
test(core): cover pnpm name@version paths in email redaction
evlogai[bot] Oct 10, 2026
3c82ff0
fix(core): stop masking pnpm store paths as email addresses
evlogai[bot] Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/redact-email-pnpm-paths.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'evlog': patch
---

Fix the built-in `email` redaction masking pnpm store paths in stack traces. Segments such as `node_modules/.pnpm/h3@1.15.11/...` were rewritten to `h***@***.11`, so drained `error.stack` values lost the package name and version. The email pattern now requires a letters-only top-level domain, so real addresses are still masked as `a***@***.com`.
3 changes: 2 additions & 1 deletion packages/evlog/src/redact.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,8 @@ export const builtinPatterns = {
},
/** Email addresses → a***@***.com */
email: {
pattern: /[\w.+-]+@[\w-]+\.[\w.]+/g,
// Letters-only TLD, so pnpm store segments like `name@1.2.3` are not treated as addresses.
pattern: /[\w.+-]+@[\w-]+(?:\.[\w-]+)*\.[a-zA-Z]{2,}\b/g,
mask: (m: string) => {
const at = m.indexOf('@')
if (at < 1) return '***@***'
Expand Down
16 changes: 16 additions & 0 deletions packages/evlog/test/core/redact-integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,6 +360,22 @@ describe('built-in smart masking', () => {
expect(event.safe).toBe('no email here')
})

it('leaves pnpm name@version store paths in stack traces untouched', () => {
let event: Record<string, unknown> = {
stack: [
'file:///app/node_modules/.pnpm/h3@1.15.11/node_modules/h3/dist/index.mjs:2007:9',
'node_modules/.pnpm/unctx@2.5.0/node_modules/unctx/dist/index.mjs:10:3',
'node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/index.js:1:1',
].join('\n'),
}
event = redactEvent(event, defined(resolveRedactConfig({ builtins: ['email'] }), 'redact config'))
expect(event.stack).toBe([
'file:///app/node_modules/.pnpm/h3@1.15.11/node_modules/h3/dist/index.mjs:2007:9',
'node_modules/.pnpm/unctx@2.5.0/node_modules/unctx/dist/index.mjs:10:3',
'node_modules/.pnpm/react-dom@18.2.0_react@18.2.0/node_modules/react-dom/index.js:1:1',
].join('\n'))
})

it('masks IPv4 addresses keeping last octet', () => {
let event: Record<string, unknown> = {
a: '192.168.1.1',
Expand Down
Loading