refactor(spark): Extract XxHash64 helper#17681
Draft
malinjawi wants to merge 1 commit into
Draft
Conversation
✅ Deploy Preview for meta-velox canceled.
|
This was referenced May 31, 2026
Build Impact AnalysisSelective Build Targets (building these covers all 20 affected)Total affected: 20/580 targets
Affected targets (20)Directly changed (1)
Transitively affected (19)
Slow path • Graph generated from PR branch |
763604a to
827bfdb
Compare
827bfdb to
fdded66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
XxHash64helper out ofHash.cppintoXxHash64.hso Spark aggregate code can reuse it.as a pure refactor.
Why:
Review notes:
Testing:
git diff --check upstream/main..pr16595-xxhash64-refactorSKIP=action-validator pre-commit run --from-ref upstream/main --to-ref pr16595-approx-count-distinct-intervalsPart of #16595.