Skip to content

refactor(spark): Extract XxHash64 helper#17681

Draft
malinjawi wants to merge 1 commit into
facebookincubator:mainfrom
malinjawi:pr16595-xxhash64-refactor
Draft

refactor(spark): Extract XxHash64 helper#17681
malinjawi wants to merge 1 commit into
facebookincubator:mainfrom
malinjawi:pr16595-xxhash64-refactor

Conversation

@malinjawi
Copy link
Copy Markdown
Contributor

@malinjawi malinjawi commented May 31, 2026

Summary:

  • Move the Spark-compatible XxHash64 helper out of Hash.cpp into
    XxHash64.h so Spark aggregate code can reuse it.
  • Keep the existing hash implementation behavior unchanged. This is intended
    as a pure refactor.
  • Add the new header to the Spark functions CMake target.

Why:

Review notes:

Testing:

  • git diff --check upstream/main..pr16595-xxhash64-refactor
  • SKIP=action-validator pre-commit run --from-ref upstream/main --to-ref pr16595-approx-count-distinct-intervals

Part of #16595.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 31, 2026

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit fdded66
🔍 Latest deploy log https://app.netlify.com/projects/meta-velox/deploys/6a1d59c6e3b77a0008084438

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 31, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 31, 2026

Build Impact Analysis

Selective Build Targets (building these covers all 20 affected)

cmake --build _build/release --target spark_expression_fuzzer_test velox_date_extract_benchmark velox_expression_runner_test velox_expression_runner_unit_test velox_functions_spark_aggregates_test velox_functions_spark_test velox_spark_function_registry_test velox_spark_query_runner_test velox_sparksql_benchmarks_cast velox_sparksql_benchmarks_compare velox_sparksql_benchmarks_from_json velox_sparksql_benchmarks_get_funcs velox_sparksql_benchmarks_hash velox_sparksql_benchmarks_in velox_sparksql_benchmarks_simd_compare velox_sparksql_benchmarks_split velox_sparksql_coverage

Total affected: 20/580 targets

Warning: 1 file(s) could not be mapped to any target. A full build may be needed.

  • velox/functions/sparksql/CMakeLists.txt
Affected targets (20)

Directly changed (1)

Target Changed Files
velox_functions_spark_impl Hash.cpp, XxHash64.h

Transitively affected (19)

  • spark_expression_fuzzer_test
  • velox_date_extract_benchmark
  • velox_expression_runner
  • velox_expression_runner_test
  • velox_expression_runner_unit_test
  • velox_functions_spark
  • velox_functions_spark_aggregates_test
  • velox_functions_spark_test
  • velox_spark_function_registry_test
  • velox_spark_query_runner_test
  • velox_sparksql_benchmarks_cast
  • velox_sparksql_benchmarks_compare
  • velox_sparksql_benchmarks_from_json
  • velox_sparksql_benchmarks_get_funcs
  • velox_sparksql_benchmarks_hash
  • velox_sparksql_benchmarks_in
  • velox_sparksql_benchmarks_simd_compare
  • velox_sparksql_benchmarks_split
  • velox_sparksql_coverage

Slow path • Graph generated from PR branch

@malinjawi malinjawi force-pushed the pr16595-xxhash64-refactor branch from 763604a to 827bfdb Compare May 31, 2026 12:06
@malinjawi malinjawi force-pushed the pr16595-xxhash64-refactor branch from 827bfdb to fdded66 Compare June 1, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant