feat(exec): Forward constant inputs in SimpleAggregateAdapter#17682
Draft
malinjawi wants to merge 2 commits into
Draft
feat(exec): Forward constant inputs in SimpleAggregateAdapter#17682malinjawi wants to merge 2 commits into
malinjawi wants to merge 2 commits into
Conversation
✅ Deploy Preview for meta-velox canceled.
|
meta-cla
Bot
added
the
CLA Signed
Build Impact AnalysisSelective Build Targets (building these covers all 319 affected)Total affected: 319/580 targets
Affected targets (319)Directly changed (7)
Transitively affected (312)
Slow path • Graph generated from PR branch |
malinjawi
force-pushed
the
pr16595-simple-aggregate-constants
branch
2 times, most recently
from
ad25003 to
b1fbbb3
Compare
malinjawi
force-pushed
the
pr16595-simple-aggregate-constants
branch
from
b1fbbb3 to
d799215
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Aggregate::setConstantInputshook throughSimpleAggregateAdapterwhen the wrapped simple aggregate function definessetConstantInputs.support_set_constant_inputs_.Why:
initializeruns during aggregate construction with types and config, butconstant argument vectors are discovered later by
AggregateInfo.AggregateInfocallsAggregate::setConstantInputsonce, before input rowsare processed, when aggregate arguments include constants. This PR lets simple
aggregate functions observe that existing hook.
Review notes:
malinjawi/velox@pr16595-xxhash64-refactor...pr16595-simple-aggregate-constants
Testing:
git diff --check pr16595-xxhash64-refactor..pr16595-simple-aggregate-constantsSKIP=action-validator pre-commit run --from-ref upstream/main --to-ref pr16595-approx-count-distinct-intervalsPart of #16595.