Skip to content

Conversation

@horsefacts
Copy link
Collaborator

@horsefacts horsefacts commented Jun 4, 2025

Motivation

Fix audit findings.

Change Summary

  • Remove unchecked increment [Q-1]
  • Add index to payer [Q-2]
  • Update contract versions to June 16.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR primarily focuses on updating version constants and improving event definitions in the smart contract code, along with adjustments to test cases and CI configuration for better reliability and performance.

Detailed summary

  • Updated VERSION in TierRegistry.sol and Bundler.sol to "2025.06.16".
  • Changed event definition for PurchasedTier to include an indexed payer parameter.
  • Modified test assertions in TestSuiteSetup.sol and TierRegistry.t.sol for updated version checks.
  • Adjusted CI workflow timeout and retry settings for improved reliability.

The following files were skipped due to too many changes: .gas-snapshot

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@horsefacts horsefacts added the chore A task that is none of the other types label Jun 4, 2025
@horsefacts horsefacts force-pushed the horsefacts/audit-fixes branch 2 times, most recently from 7eaba91 to 00816ff Compare June 4, 2025 21:40
@horsefacts horsefacts force-pushed the horsefacts/audit-fixes branch from 00816ff to 9df8734 Compare June 4, 2025 21:49
@github-actions
Copy link

github-actions bot commented Jun 4, 2025

Coverage after merging horsefacts/audit-fixes into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   Bundler.sol100%100%100%100%
   BundlerV1.sol100%100%100%100%
   FnameResolver.sol100%100%100%100%
   IdGateway.sol100%100%100%100%
   IdRegistry.sol100%100%100%100%
   KeyGateway.sol100%100%100%100%
   KeyRegistry.sol100%100%100%100%
   RecoveryProxy.sol100%100%100%100%
   StorageRegistry.sol100%100%100%100%
   TierRegistry.sol100%100%100%100%
src/abstract
   EIP712.sol100%100%100%100%
   Guardians.sol100%100%100%100%
   Migration.sol100%100%100%100%
   Nonces.sol100%100%100%100%
   Signatures.sol100%100%100%100%
src/validators
   SignedKeyRequestValidator.sol100%100%100%100%

@horsefacts horsefacts merged commit d711c78 into main Jun 4, 2025
4 checks passed
@horsefacts horsefacts deleted the horsefacts/audit-fixes branch June 4, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A task that is none of the other types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants