Show listening action in standalone note menu#5865
Merged
Conversation
✅ Deploy Preview for old-char canceled.
|
421aada to
fa105fc
Compare
fa105fc to
5aac463
Compare
29d6563 to
4129565
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4129565. Configure here.
|
|
||
| if (!cancelled) { | ||
| onHandled(request.requestId); | ||
| } |
There was a problem hiding this comment.
Stop request skipped silently
Medium Severity
In MainListenerControlRequestRunner, a delegated stop runs only when activeSessionId === request.sessionId. If they differ, the handler still calls onHandled without invoking stop(), so a standalone stop click can complete while capture on the main window keeps running.
Reviewed by Cursor Bugbot for commit 4129565. Configure here.
4c94260 to
f5d90c9
Compare
Adds the standalone listening menu action and routes listener controls through the main window.
f5d90c9 to
39df6e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Let standalone note windows render the same overflow listening action as the main note view while keeping the dedicated header stop button hidden.
Note
Low Risk
Session header and overflow UI only; listening stop still goes through existing main-window delegation with no auth or data-model changes.
Overview
Standalone note windows now expose listening controls in the header overflow menu the same way as the main note view, by passing
standaloneWindowinto the overflow button and leaving listening enabled (instead of turning it off for detached windows).The session outer header also adjusts standalone layout (title insets without the collapsed-sidebar gutter) and keeps the inline stop control available in standalone while routing stop to the main webview when needed. The diff here is mostly i18n catalog line-reference updates after those header changes moved strings such as Join, Stop, Finalizing, and Stop listening.
Reviewed by Cursor Bugbot for commit 39df6e1. Bugbot is set up for automated code reviews on this repo. Configure here.
This is part 1 of 2 in a stack made with GitButler: