Skip to content

Show listening action in standalone note menu#5865

Merged
ComputelessComputer merged 1 commit into
mainfrom
fix/standalone-listening-menu
Jul 1, 2026
Merged

Show listening action in standalone note menu#5865
ComputelessComputer merged 1 commit into
mainfrom
fix/standalone-listening-menu

Conversation

@ComputelessComputer

@ComputelessComputer ComputelessComputer commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Let standalone note windows render the same overflow listening action as the main note view while keeping the dedicated header stop button hidden.


Note

Low Risk
Session header and overflow UI only; listening stop still goes through existing main-window delegation with no auth or data-model changes.

Overview
Standalone note windows now expose listening controls in the header overflow menu the same way as the main note view, by passing standaloneWindow into the overflow button and leaving listening enabled (instead of turning it off for detached windows).

The session outer header also adjusts standalone layout (title insets without the collapsed-sidebar gutter) and keeps the inline stop control available in standalone while routing stop to the main webview when needed. The diff here is mostly i18n catalog line-reference updates after those header changes moved strings such as Join, Stop, Finalizing, and Stop listening.

Reviewed by Cursor Bugbot for commit 39df6e1. Bugbot is set up for automated code reviews on this repo. Configure here.


This is part 1 of 2 in a stack made with GitButler:

@netlify

netlify Bot commented Jul 1, 2026

Copy link
Copy Markdown

Deploy Preview for old-char canceled.

Name Link
🔨 Latest commit 39df6e1
🔍 Latest deploy log https://app.netlify.com/projects/old-char/deploys/6a4566172baadb0008678d1b

Comment thread apps/desktop/src/main/lifecycle.tsx
Comment thread apps/desktop/src/stt/window-control.tsx Outdated
Comment thread apps/desktop/src/session/components/outer-header/index.tsx
Comment thread apps/desktop/src/stt/window-control.tsx Outdated
@ComputelessComputer ComputelessComputer force-pushed the fix/standalone-listening-menu branch from fa105fc to 5aac463 Compare July 1, 2026 18:17
Comment thread apps/desktop/src/stt/window-control.tsx
@ComputelessComputer ComputelessComputer force-pushed the fix/standalone-listening-menu branch 2 times, most recently from 29d6563 to 4129565 Compare July 1, 2026 18:26

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4129565. Configure here.


if (!cancelled) {
onHandled(request.requestId);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stop request skipped silently

Medium Severity

In MainListenerControlRequestRunner, a delegated stop runs only when activeSessionId === request.sessionId. If they differ, the handler still calls onHandled without invoking stop(), so a standalone stop click can complete while capture on the main window keeps running.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 4129565. Configure here.

@ComputelessComputer ComputelessComputer force-pushed the fix/standalone-listening-menu branch 2 times, most recently from 4c94260 to f5d90c9 Compare July 1, 2026 18:50
Adds the standalone listening menu action and routes listener controls through the main window.
@ComputelessComputer ComputelessComputer force-pushed the fix/standalone-listening-menu branch from f5d90c9 to 39df6e1 Compare July 1, 2026 19:10
@ComputelessComputer ComputelessComputer merged commit a6054e0 into main Jul 1, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant