Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recalculate target Y on elements that might be moving while scrolling #115

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shank-eric
Copy link

Let me know if this is something you're interested in adding. I tried to match conventions and such, but haven't updated the README yet.

  • if the target being scrolled to is changing position while the scrolling is happening, the target position needs to be recalculated on the fly to ensure we end up at the right spot
  • this might happen if clicking a scroll link triggers other actions in the DOM that affect the Y position of the target (such as collapsing an element above the target)

* if the target being scrolled to is changing position while the scrolling is happening, the target position needs to be recalculated on the fly to ensure we end up at the right spot
* this might happen if clicking a scroll link also collapses an element above the target
@fisshy
Copy link
Owner

fisshy commented Aug 1, 2016

Thanks, looks like an useful feature. Will go through it and check it.

Would be helpful if you could write a test for it, so it doesn't break in the future.

@shank-eric
Copy link
Author

sure, I should be able to make that happen

@fisshy
Copy link
Owner

fisshy commented Aug 1, 2016

Awesome, I will check it out tomorrow and then merge it and publish it :)

@shank-eric
Copy link
Author

Thanks!

@fisshy
Copy link
Owner

fisshy commented Aug 7, 2016

Sorry about the delay, I will have time check it out in a day or two.

@beautyfree
Copy link

What is new?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants