Fix cursor not brought to view when editor is scrollable and wrapped inside scrollable - #555
Merged
Amir-P merged 6 commits intoSep 21, 2025
Conversation
…inside scrollable
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #555 +/- ##
==========================================
+ Coverage 89.24% 89.30% +0.06%
==========================================
Files 63 63
Lines 10986 10985 -1
==========================================
+ Hits 9804 9810 +6
+ Misses 1182 1175 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amantoux
approved these changes
Sep 21, 2025
amantoux
self-requested a review
September 21, 2025 07:24
amantoux
reviewed
Sep 21, 2025
amantoux
left a comment
amantoux
left a comment
Member
There was a problem hiding this comment.
Just one comment, all good for me otherwise
Member
Author
|
Thanks for pointing it out! Can you check again please? @amantoux |
amantoux
reviewed
Sep 21, 2025
Amir-P
deleted the
fix/cursor_not_brought_to_view_when_editor_is_scrollable_inside_scrollable
branch
September 21, 2025 09:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #554