Skip to content

Fix cursor not brought to view when editor is scrollable and wrapped inside scrollable #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amir-P merged 6 commits into from
Sep 21, 2025
Merged

Fix cursor not brought to view when editor is scrollable and wrapped inside scrollable #555

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6cf2a74
Fix cursor not brought to view when editor is scrollable and wrapped …
Amir-P Sep 20, 2025
a920bd6
Add test
Amir-P Sep 20, 2025
81236bc
Format
Amir-P Sep 20, 2025
f8ae0cc
Add duration
Amir-P Sep 21, 2025
09387ea
Fix tests
Amir-P Sep 21, 2025
01474c3
Update pump duration
Amir-P Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/fleather/test/widgets/editor_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1672,7 +1672,7 @@ void main() {
final newInput = 'Line1\nLine2';
controller.replaceText(0, 0, newInput,
selection: TextSelection.collapsed(offset: newInput.length));
await tester.pump(throttleDuration);
await tester.pumpAndSettle(Duration(milliseconds: 200));
Comment thread
Amir-P marked this conversation as resolved.
Outdated
expect(scrollController.position.pixels,
greaterThan(initialScrollPosition));
});
Expand Down Expand Up @@ -1718,7 +1718,7 @@ void main() {
final newInput = 'Line1\nLine2';
controller.replaceText(0, 0, newInput,
selection: TextSelection.collapsed(offset: newInput.length));
await tester.pump(throttleDuration);
await tester.pumpAndSettle(Duration(milliseconds: 200));
Comment thread
Amir-P marked this conversation as resolved.
Outdated
expect(scrollController.position.pixels,
greaterThan(initialScrollPosition));
});
Expand Down