-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support more image formats on Android #634
feat: Support more image formats on Android #634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ueman
thanks for your contribution.
all looks good
Can you make the semantic PR pass ?
@ueman : Thanks for your contribution, could you add a similar comment you added for Android but for iOS. Also, bump the version to And update CHANGELOG: |
@ueman : it has been merged into develop branch, I will test with example app and release the new version ASAP |
Thanks for the contribution |
Hey any news for the production? I think this would be huge |
This was already released, see https://pub.dev/packages/google_mlkit_commons/changelog |
Instead of hardcoding a specific format, we're now properly using the correct format as specified on the Dart side.
In case an invalid image format was used, this throws the following exception: