Fix SDK browsing NPE in `FlutterSettingsConfigurable` #8102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jwren merged 1 commit into flutter:master from pq:fix_FlutterSettingsConfigurable_npe

Apr 23, 2025

Contributor

pq commented Apr 23, 2025 •

edited

Loading

If no file is selected, the file chooser will return null. This guards against that.

Fixes: #8069

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our [contributor guide](https://github.com/dart-lang/sdk/blob/main/CONTRIBUTING.md for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Dart contributions to our repos should follow the Dart style guide and use dart format.
Java and Kotlin contributions should strive to follow Java and Kotlin best practices (discussion).


          Fix SDK browsing NPE in FlutterSettingsConfigurable

7f2998c

pq requested a review from jwren

April 23, 2025 17:00

jwren approved these changes

View reviewed changes

jwren merged commit aa64df5 into flutter:master

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet