Skip to content

Fix SDK browsing NPE in FlutterSettingsConfigurable #8102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Fix SDK browsing NPE in FlutterSettingsConfigurable #8102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion flutter-idea/src/io/flutter/sdk/FlutterSettingsConfigurable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ protected void textChanged(@NotNull final DocumentEvent e) {
}

private void createUIComponents() {
//noinspection DialogTitleCapitalization
ExtendableTextComponent.Extension browseExtension =
ExtendableTextComponent.Extension.create(
AllIcons.General.OpenDisk,
Expand All @@ -149,7 +150,10 @@ private void createUIComponents() {
() -> {
FileChooserDescriptor descriptor = FileChooserDescriptorFactory.createSingleFolderDescriptor();
VirtualFile file = FileChooser.chooseFile(descriptor, mySdkCombo, null, null);
mySdkCombo.setItem(file.getPath());
if (file != null) {
//noinspection DataFlowIssue (sure to be set before the extension is invoked)
mySdkCombo.setItem(file.getPath());
}
});
mySdkCombo = new ComboBox<>();
mySdkCombo.setEditor(new BasicComboBoxEditor() {
Expand Down