logic changes for selection cancellation by Doublonmousse · Pull Request #1139 · flxzt/rnote

Doublonmousse · 2024-07-11T17:45:15Z

Fixes #414

This fixes the small dots that appears on selection cancellation with the pen (whilst allowing for strokes to still be written if they're larger than small dots)

A couple remarks :

shapes need an additional up/down cycle : we could change it to follow the same logic as the brush but this could also be done by not changing the logic of the shape part and only disallowing shapes to be too small (in that case we can create shapes that aren't even visible but are still part of the document)
the eraser and typewriter both need an additional pen up/down to activate
tools aren't affected (they won't change anything if they're activated on such a short pen down/up cycle)
~~This does not change behavior when a selection is deleted.~~

Doublonmousse · 2024-07-11T19:21:09Z

I've added a condition to only create shapes if they're large enough. As things like arrows would still appear on a single pen event, I'll leave the current behavior for shapes after a selection cancellation (that is we need an extra up/down cycle)

Doublonmousse · 2024-07-13T14:41:21Z

I've added the cancellation of the selection tool upon deleting a selection when the selection tool is temporary

fixes bug where large vertical or horizontal elements would get cancelled

- move actions logic into `trash_selection` - small rename of canceled* to have coherent naming between variables and functions getters/settesr - move comment closer to the `canceled_state` variable (variable-level docstring) - constant added as such

* Update translation files Updated by "Update LINGUAS file" hook in Weblate. Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/ * Translated using Weblate (Hebrew) Currently translated at 99.2% (547 of 551 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/he/ * Added translation using Weblate (English (Middle)) * Translated using Weblate (Finnish) Currently translated at 93.6% (516 of 551 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/fi/ * Translated using Weblate (Portuguese) Currently translated at 38.2% (211 of 551 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/pt/ * Translated using Weblate (Bengali) Currently translated at 100.0% (551 of 551 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/bn/ * Translated using Weblate (Portuguese) Currently translated at 46.2% (255 of 551 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/pt/ * Added translation using Weblate (Romanian) * Translated using Weblate (Romanian) Currently translated at 0.7% (4 of 551 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/ro/ * Translated using Weblate (Romanian) Currently translated at 1.4% (8 of 551 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/ro/ * Translated using Weblate (Bengali) Currently translated at 100.0% (551 of 551 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/bn/ --------- Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com> Co-authored-by: Brayden Tsang <brayttt1304.school@gmail.com> Co-authored-by: Jiri Grönroos <jiri.gronroos@iki.fi> Co-authored-by: Initdd <joaomariagoncalves@sapo.pt> Co-authored-by: Ritam Saha <ritamsaha00@gmail.com> Co-authored-by: Joel Pinto <geral.joelpinto@gmail.com> Co-authored-by: Andrea Andre <andrea.tsg19@slmail.me>

referenced issue: flxzt#220

… mode This allows one element to be resized/rotated in this mode even if a stroke/image is behind. The old behavior can be forced in this mode when pressing `Shift`

…lxzt#1285) * make zooming consistent make zoom consistent Take 1/zoom_in for zoom_out so that doing one zoom in then one zoom out ends up back to the same place add more accelerators for zoom and keypad - accelerator to reset zoom : ctrl + 0 (be it on the keyboard or numpad) - added accelerators for keypad 1 to 6 for the selection of tools - add `ctrl + =` for zoom in - add `ctrl + +` and `ctrl + -` for + and - the numpad keys * fmt

fixes deprecation warnings and prevents invalid installer file names

…lxzt#1281) * fix: improve the clipboard pasting of files for better cross compatibility use `read_future(&["text/uri-list") ...` instead of `read_text_future` when pasting files. This will make it work on the next gtk stable release (4.18) on mac os * cleanup: use helper function for all `InputStream` to `Vec<u8>` reads

* highlight nodes when the pen or mouse hovers when text is selected * do not deselect text when the pen hovers

* refactor: reinstall pen only if necessary * refactor: clean up select_all

Doublonmousse · 2025-02-02T09:46:44Z

Putting back in draft as this needs a little work before it can be merged.
I'm wondering if the condition can be slightly modified to include time delay as well. It will cancel a dot after a selection but sometimes this dot can be large enough to stay (if the pen slides a bit instead of a clean hit)

Switches to the maintained flathub fork of the flatpak builder action.

* Update translation files Updated by "Update LINGUAS file" hook in Weblate. Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/ * Translated using Weblate (Italian) Currently translated at 100.0% (556 of 556 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/it/ * Added translation using Weblate (Basque) * Translated using Weblate (Dutch) Currently translated at 98.3% (547 of 556 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/nl/ * Translated using Weblate (Indonesian) Currently translated at 46.0% (256 of 556 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/id/ * Translated using Weblate (Portuguese) Currently translated at 45.8% (255 of 556 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/pt/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 80.3% (447 of 556 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/pt_BR/ * Translated using Weblate (French) Currently translated at 98.7% (549 of 556 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/fr/ * Translated using Weblate (Persian) Currently translated at 37.4% (208 of 556 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/fa/ * Translated using Weblate (Portuguese) Currently translated at 46.0% (256 of 556 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/pt/ * Translated using Weblate (Dutch) Currently translated at 100.0% (556 of 556 strings) Translation: rnote/repo Translate-URL: https://hosted.weblate.org/projects/rnote/repo/nl/ --------- Co-authored-by: Matteo Ballabio <matteo@ballabio.dev> Co-authored-by: Peio Urrutibeaskoa <peiourrutibeaskoa@gmail.com> Co-authored-by: Timo <timovdvenne@gmail.com> Co-authored-by: Darnivo <darrenivano04@gmail.com> Co-authored-by: Pedro Wasconcelos <pedro.wasconcelos@proton.me> Co-authored-by: Adrien Lesage <adrienlesage2005@gmail.com> Co-authored-by: Tooraj Taraz <tooraj.taraz@yahoo.com> Co-authored-by: Pavel Ovchinnikov <opavel@internet.ru>

referenced issue: flxzt#220

…zt#1365)

…#1381) fixes program not using on_conflict when terminal non-interactive

by using a patched poppler-rs. This is a workaround until the issue is fixed upstream.

…on fmt (flxzt#1396)

referenced issue: flxzt#220

…o no_spots

Doublonmousse added 2 commits July 11, 2024 19:40

logic changes for selection cancellation

f27f312

prevent shapes that are too small to be visible

ace0b25

Doublonmousse added 2 commits July 13, 2024 16:38

close selection tool when deleting in temporary mode

5d5d149

fmt

1f14479

Doublonmousse marked this pull request as ready for review July 13, 2024 14:41

Doublonmousse commented Jul 21, 2024

View reviewed changes

Comment thread crates/rnote-engine/src/pens/shaper.rs Outdated

remove unnecessary size check

5b9807c

fixes bug where large vertical or horizontal elements would get cancelled

flxzt reviewed Nov 2, 2024

View reviewed changes

Comment thread crates/rnote-ui/src/appwindow/actions.rs Outdated

flxzt reviewed Nov 2, 2024

View reviewed changes

Comment thread crates/rnote-engine/src/pens/brush.rs Outdated

flxzt reviewed Nov 2, 2024

View reviewed changes

Comment thread crates/rnote-engine/src/pens/selector/penevents.rs Outdated

Doublonmousse and others added 11 commits November 2, 2024 15:59

apply corrections

3cca287

- move actions logic into `trash_selection` - small rename of canceled* to have coherent naming between variables and functions getters/settesr - move comment closer to the `canceled_state` variable (variable-level docstring) - constant added as such

Merge branch 'flxzt:main' into no_spots

99406ca

switch to hashset to fix type error

32573ed

fmt check

430c77f

chore: update piet, rough dependencies

97f9fd0

fix: deselect 9th colorsetter after selecting 7th, fixes flxzt#1255

331272c

i18n: Update traditional Chinese translation

f4de1fc

referenced issue: flxzt#220

feat: Open workspace folder option (flxzt#1272)

d448b4c

improv: support keypad and uncommon keys (flxzt#1274)

a9bb13b

feat: Allow import of encrypted PDF files (flxzt#1279)

7f3ff8a

Doublonmousse mentioned this pull request Nov 9, 2024

Unable to make a new selection with pen button while having another active selection. #888

Open

Doublonmousse and others added 6 commits November 21, 2024 14:57

fix: selection resize/rotate handle sensitivity in 'single' selection…

d7f0636

… mode This allows one element to be resized/rotated in this mode even if a stroke/image is behind. The old behavior can be forced in this mode when pressing `Shift`

ci: sanitize ref name, update deprecated actions

c8f283c

fixes deprecation warnings and prevents invalid installer file names

refactor: use macros for constructing engine views (flxzt#1306)

1bca5c9

chore: satisfy latest clippy

47d01a2

Doublonmousse and others added 8 commits December 24, 2024 11:54

fix: change logic to keep text selection on hover/pen up (flxzt#1326)

0d753c1

* highlight nodes when the pen or mouse hovers when text is selected * do not deselect text when the pen hovers

refactor: reinstall pen only if necessary (flxzt#1321)

9ab5398

* refactor: reinstall pen only if necessary * refactor: clean up select_all

chore: consistent output for fields without debug impl

2ef66c5

chore: update to gtk4.16 feature

5719191

chore: add gtk4, poppler as system deps in meson build file

081d878

chore: remove outdated, commented out code in meson build file

779d4b3

fix: ci by updating containers

5711791

i18n: Completed Nepali translation (flxzt#1342)

e72fc90

Doublonmousse marked this pull request as draft February 2, 2025 09:43

Kneemund and others added 18 commits February 4, 2025 10:03

ci: fix nightly builds

a30213d

Switches to the maintained flathub fork of the flatpak builder action.

feat: multi-click selections (flxzt#1268)

58087a1

i18n: Update traditional Chinese translation

45f76f0

referenced issue: flxzt#220

chore: update to rust 2024 edition, v1.85 msrv, update deps, fmt (flx…

0fcb985

…zt#1365)

fix: cli file collision resolution in non-interactive settings (flxzt…

119e951

…#1381) fixes program not using on_conflict when terminal non-interactive

i18n: Add Esperanto translation language (flxzt#1380)

fb85009

feat: add thumbnailer (flxzt#1377)

a70bbf3

chore: bump flatpak GNOME runtime to version 48 (flxzt#1391)

a5822ac

fix: failing build on windows due to broken poppler-rs (flxzt#1282)

972fa2e

by using a patched poppler-rs. This is a workaround until the issue is fixed upstream.

chore: add justfile for common tasks, adapt CI, apply YAML lints, mes…

ee621e0

…on fmt (flxzt#1396)

i18n: Update traditional Chinese translation

b4ba5a9

referenced issue: flxzt#220

chore: fix just recipe RUST_LOG env var, docs

69f72e8

fix: missing tooltips (flxzt#1401)

2b3972f

i18n: Translations update from Hosted Weblate (flxzt#1362)

dfb9f88

i18n: Update traditional Chinese translation

bae2a2f

referenced issue: flxzt#220

fix: window shadows on Windows (flxzt#1403)

6c62026

Merge branch 'no_spots' of https://github.com/Doublonmousse/rnote int…

82bb690

…o no_spots

Doublonmousse closed this Apr 6, 2025

Doublonmousse mentioned this pull request Apr 6, 2025

Improv : logic changes for selection cancellation #1405

Open

Navigation Menu

Uh oh!

logic changes for selection cancellation - #1139

logic changes for selection cancellation#1139
Doublonmousse wants to merge 60 commits into
flxzt:mainfrom
Doublonmousse:no_spots

Doublonmousse commented Jul 11, 2024 •

edited

Loading

Uh oh!

Doublonmousse commented Jul 11, 2024

Uh oh!

Doublonmousse commented Jul 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Doublonmousse commented Feb 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

Doublonmousse commented Jul 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Doublonmousse commented Jul 11, 2024

Uh oh!

Doublonmousse commented Jul 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Doublonmousse commented Feb 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Doublonmousse commented Jul 11, 2024 •

edited

Loading