logic changes for selection cancellation

.github/FUNDING.yml

@@ -1,13 +1,15 @@
+---
+
 # These are supported funding model platforms
 
-github: [flxzt] # Replace with up to 4 GitHub Sponsors-enabled usernames e.g., [user1, user2]
-patreon: # Replace with a single Patreon username
-open_collective: # Replace with a single Open Collective username
-ko_fi: # Replace with a single Ko-fi username
-tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel
-community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry
-liberapay: flxzt # Replace with a single Liberapay username
-issuehunt: # Replace with a single IssueHunt username
-otechie: # Replace with a single Otechie username
-lfx_crowdfunding: # Replace with a single LFX Crowdfunding project-name e.g., cloud-foundry
-#custom: [] # Replace with up to 4 custom sponsorship URLs e.g., ['link1', 'link2']
+github: [flxzt]     # Replace with up to 4 GitHub Sponsors-enabled usernames e.g., [user1, user2]
+patreon:            # Replace with a single Patreon username
+open_collective:    # Replace with a single Open Collective username
+ko_fi:              # Replace with a single Ko-fi username
+tidelift:           # Replace with a single Tidelift platform-name/package-name e.g., npm/babel
+community_bridge:   # Replace with a single Community Bridge project-name e.g., cloud-foundry
+liberapay: flxzt    # Replace with a single Liberapay username
+issuehunt:          # Replace with a single IssueHunt username
+otechie:            # Replace with a single Otechie username
+lfx_crowdfunding:   # Replace with a single LFX Crowdfunding project-name e.g., cloud-foundry
+# custom: []         # Replace with up to 4 custom sponsorship URLs e.g., ['link1', 'link2']

.github/workflows/ci.yml

@@ -1,6 +1,8 @@
+---
+
 name: CI
 
-on:
+"on":
   push:
     branches:
       - main
@@ -15,24 +17,24 @@ env:
 jobs:
   check:
     if: github.event.pull_request.draft == false
-    runs-on: ubuntu-22.04
-    container: fedora:40
+    runs-on: ubuntu-24.04
+    container: fedora:41
     steps:
-      - name: Install core dependencies
-        run: |
-          sudo dnf upgrade --refresh -y
-          sudo dnf install -y gcc gcc-c++ clang python3 make cmake meson git kernel-devel gtk4-devel libadwaita-devel poppler-glib-devel poppler-data alsa-lib-devel appstream-devel desktop-file-utils
-      - name: Install additional tools
-        uses: taiki-e/install-action@v2
-        with:
-          tool: nextest
-      - name: Install toolchain
+
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Install rust toolchain
         id: toolchain
         uses: dtolnay/rust-toolchain@stable
         with:
           components: rustfmt, clippy
-      - name: Checkout
-        uses: actions/checkout@v4
+
+      - name: Prerequisites
+        run: |
+          dnf install -y just lsb_release
+          just ci=true prerequisites-dev
+
       - name: Cache
         uses: actions/cache@v4
         env:
@@ -44,34 +46,29 @@ jobs:
             _mesonbuild/cargo-home/registry/cache/
             _mesonbuild/cargo-home/git/db/
             _mesonbuild/target/
-          key: cargo-${{ runner.os }}-${{ steps.toolchain.outputs.cachekey }}-${{ hashFiles('**/Cargo.lock') }}-${{ github.workflow_sha }}
+          key: "cargo-${{ runner.os }}-${{ steps.toolchain.outputs.cachekey }}-
+            ${{ hashFiles('**/Cargo.lock') }}-${{ github.workflow_sha }}"
           restore-keys: cargo-${{ runner.os }}-${{ steps.toolchain.outputs.cachekey }}
+
       - name: Setup
-        run: |
-          meson setup --prefix=/usr -Dprofile=devel -Dcli=true -Dci=true _mesonbuild
+        run: just ci=true setup-dev
+
       - name: Run fmt check
-        run: meson compile cargo-fmt-check -C _mesonbuild
-      - name: Compile
-        run: meson compile -v -C _mesonbuild
+        run: just ci=true fmt-check
+
+      - name: Build
+        run: just ci=true build
+
       - name: Install
-        run: meson install -C _mesonbuild
-      - name: Run cargo tests
-        run: meson compile cargo-test -C _mesonbuild
-      - name: Run meson tests
-        run: meson test -v -C _mesonbuild
-      - name: Run clippy for UI
-        run: meson compile ui-cargo-clippy -C _mesonbuild
-        continue-on-error: true
-      - name: Run clippy for CLI
-        run: meson compile cli-cargo-clippy -C _mesonbuild
+        run: just ci=true install
+
+      - name: Test
+        run: just ci=true test
+
+      - name: Lint
+        run: just ci=true lint
         continue-on-error: true
-      - name: Run file compatibility tests
-        run: |
-          rnote-cli test\
-            misc/file-tests/v0-5-5-test.rnote\
-            misc/file-tests/v0-5-13-test.rnote\
-            misc/file-tests/v0-6-0-test.rnote\
-            misc/file-tests/v0-9-0-test.rnote\
+
       - name: Upload test report
         uses: actions/upload-artifact@v4
         if: success() || failure()

.github/workflows/dist.yml

@@ -1,52 +1,71 @@
+---
+
 name: Generate Dist Archive
 
-on:
+"on":
   release:
     types: [published]
   workflow_dispatch:
 
 jobs:
   dist:
-    runs-on: ubuntu-22.04
-    container: fedora:40
+    runs-on: ubuntu-24.04
+    container: fedora:41
     permissions:
-      contents: write # needed for uploading release artifact
+      # needed for uploading release artifact
+      contents: write
     steps:
-      - name: Install dependencies
+
+      # Necessary so that 'Checkout' will clone as repository, which the `meson dist` commands needs.
+      - name: Install git
         run: |
-          sudo dnf upgrade --refresh -y
-          sudo dnf install -y gcc gcc-c++ clang python3 make cmake meson git gh kernel-devel gtk4-devel libadwaita-devel poppler-glib-devel poppler-data alsa-lib-devel appstream-devel desktop-file-utils
-      - name: Install toolchain
-        id: toolchain
-        uses: dtolnay/rust-toolchain@stable
+          dnf install -y git
+
       - name: Checkout
         uses: actions/checkout@v4
         with:
           fetch-depth: 0
+
       - name: Add workspace as git safe directory
         run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
-      - name: Setup
+
+      - name: Install rust toolchain
+        id: toolchain
+        uses: dtolnay/rust-toolchain@stable
+
+      - name: Prerequisites
         run: |
-          meson setup --prefix=/usr _mesonbuild
-      - name: Run meson dist
-        run: meson dist --no-tests -C _mesonbuild
+          dnf install -y just lsb_release
+          just ci=true prerequisites
+
+      - name: Setup
+        run: just ci=true setup-release
+
+      - name: Create tarball
+        run: just ci=true create-tarball
+
       - name: Register archive file names
         id: register_archive_file_names
         run: |
           echo "archive=$(basename _mesonbuild/meson-dist/rnote-*.tar.xz | tail -n1)" >> $GITHUB_OUTPUT
           echo "sha=$(basename _mesonbuild/meson-dist/rnote-*.tar.xz.sha256sum | tail -n1)" >> $GITHUB_OUTPUT
+
       - name: Upload dist archive (Workflow Artifact)
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: rnote-dist-archive-artifact
           path: |
             _mesonbuild/meson-dist/${{ steps.register_archive_file_names.outputs.archive }}
             _mesonbuild/meson-dist/${{ steps.register_archive_file_names.outputs.sha }}
+          include-hidden-files: true
           if-no-files-found: error
+
       - name: Upload dist archive (Release Asset)
         if: ${{ github.event_name == 'release' }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
-          gh release upload ${{ github.ref_name }} _mesonbuild/meson-dist/${{ steps.register_archive_file_names.outputs.archive }}
-          gh release upload ${{ github.ref_name }} _mesonbuild/meson-dist/${{ steps.register_archive_file_names.outputs.sha }}
+          gh release upload ${{ github.ref_name }} \
+            _mesonbuild/meson-dist/${{ steps.register_archive_file_names.outputs.archive }}
+          gh release upload ${{ github.ref_name }} \
+            _mesonbuild/meson-dist/${{ steps.register_archive_file_names.outputs.sha }}

.github/workflows/nightly.yml

@@ -1,6 +1,8 @@
+---
+
 name: Nightly
 
-on:
+"on":
   schedule:
     - cron: "0 8 * * 1"
   workflow_dispatch:
@@ -10,14 +12,18 @@ jobs:
   flatpak:
     runs-on: ubuntu-latest
     container:
-      image: bilelmoussaoui/flatpak-github-actions:gnome-47
+      image: ghcr.io/flathub-infra/flatpak-github-actions:gnome-47
       options: --privileged
     steps:
-    - uses: actions/checkout@v4
-    - uses: flatpak/flatpak-github-actions/flatpak-builder@v6
-      with:
-        manifest-path: build-aux/com.github.flxzt.rnote.Devel.yaml
-        cache-key: flatpak-builder-${{ github.sha }}
-        arch: x86_64
-        build-bundle: true
-        bundle: com.github.flxzt.rnote.Devel.flatpak
+
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Build nightly flatpak
+        uses: flathub-infra/flatpak-github-actions/flatpak-builder@4388a4c5fc8bab58e1dfb7fc63267dca0f7b4976
+        with:
+          manifest-path: build-aux/com.github.flxzt.rnote.Devel.yaml
+          cache-key: flatpak-builder-${{ github.sha }}
+          arch: x86_64
+          build-bundle: true
+          bundle: com.github.flxzt.rnote.Devel.flatpak

.github/workflows/release-windows.yml

@@ -1,6 +1,8 @@
+---
+
 name: Release Windows
 
-on:
+"on":
   release:
     types: [published]
   workflow_dispatch:
@@ -9,50 +11,60 @@ jobs:
   build:
     runs-on: windows-2022
     permissions:
-      contents: write # needed for uploading release artifact
+      # needed for uploading release artifact
+      contents: write
     defaults:
       run:
         shell: msys2 {0}
     steps:
+
       - name: Set installer name
         id: set_installer_name
         shell: bash
-        run: echo "name=rnote-win-installer-$(echo ${GITHUB_REF_NAME#v})-x86_64" >> $GITHUB_OUTPUT
+        run: |
+          echo "name=rnote-win-installer-$(echo ${GITHUB_REF_NAME#v} \
+            | sed -e 's/[^A-Za-z0-9._-]/_/g')-x86_64" >> $GITHUB_OUTPUT
+
       - name: Setup MSYS2
         uses: msys2/setup-msys2@v2
         with:
           release: false
           update: true
           install: |
-            git mingw-w64-x86_64-xz mingw-w64-x86_64-pkgconf mingw-w64-x86_64-gcc mingw-w64-x86_64-clang mingw-w64-x86_64-toolchain
-            mingw-w64-x86_64-autotools mingw-w64-x86_64-make mingw-w64-x86_64-cmake mingw-w64-x86_64-meson mingw-w64-x86_64-diffutils
-            mingw-w64-x86_64-desktop-file-utils mingw-w64-x86_64-appstream mingw-w64-x86_64-gtk4 mingw-w64-x86_64-libadwaita
-            mingw-w64-x86_64-poppler mingw-w64-x86_64-poppler-data mingw-w64-x86_64-angleproject
-      - name: Remove libpthread.dll.a
-        run: rm /mingw64/lib/libpthread.dll.a
-        continue-on-error: true
-      - name: Install toolchain
+            mingw-w64-x86_64-binutils
+
+      - name: Install rust toolchain
         uses: dtolnay/rust-toolchain@stable
         with:
           toolchain: stable-gnu
+
       - name: Configure PATH
         run: echo "export PATH=$PATH:/c/Users/$USER/.cargo/bin:/c/Program\ Files\ \(x86\)/Inno\ Setup\ 6" > ~/.bashrc
+
       - name: Checkout
         uses: actions/checkout@v4
+
+      - name: Prerequisites
+        run: |
+          cargo install --locked just
+          just ci=true prerequisites-win
+
       - name: Setup
-        run: meson setup --prefix=C:/msys64/mingw64 -Dwin-installer-name='${{ steps.set_installer_name.outputs.name }}' _mesonbuild
-      - name: Generate locale files
-        run: meson compile rnote-gmo -C _mesonbuild
-      - name: Compile
-        run: meson compile -v -C _mesonbuild
+        run: just ci=true setup-win '${{ steps.set_installer_name.outputs.name }}'
+
+      - name: Build
+        run: just ci=true build
+
       - name: Build installer
-        run: meson compile build-installer -C _mesonbuild
+        run: just ci=true build-win-installer
+
       - name: Upload installer (Workflow Artifact)
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: rnote-win-installer-artifact
           path: _mesonbuild/${{ steps.set_installer_name.outputs.name }}.exe
           if-no-files-found: error
+
       - name: Upload installer (Release Asset)
         if: ${{ github.event_name == 'release' }}
         shell: powershell

.github/workflows/test-report.yml

@@ -1,6 +1,8 @@
+---
+
 name: 'Test Report'
 
-on:
+"on":
   workflow_run:
     workflows: ['CI']
     types:
@@ -15,9 +17,11 @@ jobs:
   report:
     runs-on: ubuntu-latest
     steps:
-    - uses: dorny/test-reporter@v1
-      with:
-        artifact: test-results
-        name: Tests
-        path: 'test-report-junit.xml'
-        reporter: java-junit
+
+      - name: Report Test Results
+        uses: dorny/test-reporter@v1
+        with:
+          artifact: test-results
+          name: Tests
+          path: 'test-report-junit.xml'
+          reporter: java-junit