use Helm to init rustfs in sandbox based on main branch#7310
Open
BarryWu0812 wants to merge 13 commits intoflyteorg:mainfrom
Open
use Helm to init rustfs in sandbox based on main branch#7310BarryWu0812 wants to merge 13 commits intoflyteorg:mainfrom
BarryWu0812 wants to merge 13 commits intoflyteorg:mainfrom
Conversation
Signed-off-by: Barry Wu <[email protected]>
Signed-off-by: Barry Wu <[email protected]>
Signed-off-by: Barry Wu <[email protected]>
Signed-off-by: Barry Wu <[email protected]>
Signed-off-by: Barry Wu <[email protected]>
Signed-off-by: Barry Wu <[email protected]>
Signed-off-by: Barry Wu <[email protected]>
Signed-off-by: Barry Wu <[email protected]>
…ent in kustomization yaml Signed-off-by: Barry Wu <[email protected]>
3 tasks
Contributor
Author
pingsutw
reviewed
Apr 29, 2026
pingsutw
previously approved these changes
Apr 30, 2026
BarryWu0812
force-pushed
the
pr-7233-main
branch
from
9ea5cfc to
5351084
Compare
Signed-off-by: Kevin Su <[email protected]>
pingsutw
requested changes
May 1, 2026
Comment on lines
-88
to
-90
| {{- define "flyte-devbox.persistence.rustfsVolumeName" -}} | ||
| {{- printf "%s-rustfs-storage" .Release.Name -}} | ||
| {{- end }} |
Member
There was a problem hiding this comment.
We still need PersistentVolume for rustfs. we need to make sure rustfs bucket has all the inputs/ouptuts files after restarting the devbox
Signed-off-by: Barry Wu <[email protected]>
Signed-off-by: Barry Wu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #7209
Why are the changes needed?
According to rustfs doc, we can run it with helm chart instead of scripting the yaml on our own.
We run an init container to create default bucket now because rustfs do not support default bucket config now. After migrating to helmchart, we can run a k8s post-install Job to create default bucket.
What changes were proposed in this pull request?
Use Helm to init rustfs in sandbox and run k8s post-install Job to create default bucket.
How was this patch tested?
Run make sandbox-build.
Run an example workflow and make sure the result is success.
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link