Fix incorrect "not found" error check.#7363
Merged
Sovietaced merged 1 commit intoMay 15, 2026
Merged
Conversation
So far, the command line parsing code would check the error returned by `FetchAndUnDecorateMatchableAttr` for a gRPC "not found" error but `AdminFetcherExtClient` maps this gRPC code to an internal `NotFoundError` type: It is this error that we need to check for. This PR adapts the error check, which unbreaks config file generation. (While at it, I also added a missing '\n' to a log message.) Signed-off-by: Philipp Winter <[email protected]>
Sovietaced
force-pushed
the
fix-broken-error-check
branch
from
b2fd0ea to
4e9abfd
Compare
Member
|
I checked the code and this seems sound to me. |
Sovietaced
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
So far, the following command would fail:
The attribute file is not written.
What changes were proposed in this pull request?
The above command failed because the command line parsing code would check the error returned by
FetchAndUnDecorateMatchableAttrfor a gRPC "not found" error butAdminFetcherExtClientmaps this gRPC code to an internalNotFoundErrortype: It is this error that we need to check for.This PR adapts the error check, which unbreaks attribute file generation. (While at it, I also added a missing '\n' to a log message.)
How was this patch tested?
I ran the above command again. It now works.
Check all the applicable boxes