Skip to content

Fix incorrect "not found" error check. #7363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sovietaced merged 1 commit into from
May 15, 2026
Merged

Fix incorrect "not found" error check. #7363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flytectl/cmd/config/subcommand/matchable_attr_file_config_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func DumpTaskResourceAttr(matchableAttrConfig interface{}, fileName string) erro
if err := WriteConfigToFile(matchableAttrConfig, fileName); err != nil {
return fmt.Errorf("error dumping in file due to %v", err)
}
fmt.Printf("wrote the config to file %v", fileName)
fmt.Printf("wrote the config to file %v\n", fileName)
} else {
fmt.Printf("%v", String(matchableAttrConfig))
}
Expand Down
5 changes: 2 additions & 3 deletions flytectl/cmd/get/matchable_workflow_execution_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,9 @@ import (
sconfig "github.com/flyteorg/flyte/flytectl/cmd/config/subcommand"
"github.com/flyteorg/flyte/flytectl/cmd/config/subcommand/workflowexecutionconfig"
cmdCore "github.com/flyteorg/flyte/flytectl/cmd/core"
"github.com/flyteorg/flyte/flytectl/pkg/ext"
"github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/admin"
"github.com/flyteorg/flyte/flyteidl/gen/pb-go/flyteidl/core"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
)

const (
Expand Down Expand Up @@ -141,7 +140,7 @@ func getWorkflowExecutionConfigFunc(ctx context.Context, args []string, cmdCtx c
// Updates the workflowExecutionConfigFileConfig with the fetched matchable attribute
if err := FetchAndUnDecorateMatchableAttr(ctx, project, domain, workflowName, cmdCtx.AdminFetcherExt(),
&workflowExecutionConfigFileConfig, admin.MatchableResource_WORKFLOW_EXECUTION_CONFIG); err != nil {
if grpcError := status.Code(err); grpcError == codes.NotFound && workflowexecutionconfig.DefaultFetchConfig.Gen {
if ext.IsNotFoundError(err) && workflowexecutionconfig.DefaultFetchConfig.Gen {
fmt.Println("Generating a sample workflow execution config file")
workflowExecutionConfigFileConfig = getSampleWorkflowExecutionFileConfig(project, domain, workflowName)
} else {
Expand Down
Loading