Skip to content

Conversation

@JRosenkranz
Copy link
Contributor

Description of the change

Added an import as part of fp8 addons as this should not be required by the user and should happen implicitly.

Related issues or PRs

foundation-model-stack/aiu-fms-testing-utils#103

How to verify the PR

To verify the PR, run test_decoders in aftu with the following variables:

FMS_TEST_SHAPES_SKIP_ASSERTIONS=mean_diff 
FMS_TEST_SHAPES_USE_MICRO_MODELS=0 
FMS_TEST_SHAPES_COMMON_MODEL_PATHS=ibm-ai-platform/micro-g3.3-8b-instruct-1b-FP8  
FMS_TEST_SHAPES_COMMON_BATCH_SIZES=1 
FMS_TEST_SHAPES_COMMON_SEQ_LENGTHS=128 
FMS_TEST_SHAPES_FAILURE_THRESHOLD=0.06 
FMS_TEST_SHAPES_ATTN_TYPE=math_fp8

Was the PR tested

  • I have added >=1 unit test(s) for every new method I have added (if that coverage is difficult, please briefly explain the reason)
  • I have ensured all unit tests pass

Checklist for passing CI/CD:

  • All commits are signed showing "Signed-off-by: Name <[email protected]>" with git commit -signoff or equivalent
  • PR title and commit messages adhere to Conventional Commits
  • Contribution is formatted with tox -e fix
  • Contribution passes linting with tox -e lint
  • Contribution passes spellcheck with tox -e spellcheck
  • Contribution passes all unit tests with tox -e unit

Note: CI/CD performs unit tests on multiple versions of Python from a fresh install. There may be differences with your local environment and the test environment.

Copy link
Collaborator

@tharapalanivel tharapalanivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tharapalanivel tharapalanivel changed the title fixed fp8 import so as to not require user to import fix: fixed fp8 import so as to not require user to import Aug 6, 2025
@github-actions github-actions bot added the fix label Aug 6, 2025
@ani300 ani300 mentioned this pull request Aug 6, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants