Skip to content

feat(invariant): shrink failure when replayed #12351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2025
Merged

feat(invariant): shrink failure when replayed #12351

merged 2 commits into from
Nov 4, 2025

Conversation

@grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Oct 29, 2025 •
edited
Loading

Motivation

Solution

  • refactor code to reuse and replay failure with shrink. Useful when campaign is ctrl-c before all shrink runs ends, on subsequent runs the sequence will be minimized
  • display warning inline in progress bar
image

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy grandizzy marked this pull request as ready for review October 29, 2025 08:34
@grandizzy grandizzy self-assigned this Oct 30, 2025
@grandizzy grandizzy moved this to Ready For Review in Foundry Oct 30, 2025
@jenpaff jenpaff added this to the v1.6.0 milestone Nov 3, 2025
DaniPopes
DaniPopes approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grandizzy grandizzy added this pull request to the merge queue Nov 4, 2025
Merged via the queue into master with commit 4370782 Nov 4, 2025
15 checks passed
@grandizzy grandizzy deleted the gdzy/issue-12333 branch November 4, 2025 11:41
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Foundry Nov 4, 2025
@rplusq rplusq mentioned this pull request Nov 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@0xrusowsky 0xrusowsky Awaiting requested review from 0xrusowsky 0xrusowsky is a code owner

Assignees

@grandizzy grandizzy

@DaniPopes DaniPopes

Labels

None yet

Projects

Foundry
Status: Done

Milestone

v1.6.0

Development

Successfully merging this pull request may close these issues.

feat(invariant): replaying failures to continue shrinking bug(invariant): warnings get cut off by --show-progress UI

4 participants

@grandizzy @DaniPopes @jenpaff