Makes franka::Error trivially copyable#88
Open
samzapo wants to merge 2 commits intofrankarobotics:masterfrom
Open
Makes franka::Error trivially copyable#88samzapo wants to merge 2 commits intofrankarobotics:masterfrom
franka::Error trivially copyable#88samzapo wants to merge 2 commits intofrankarobotics:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a
std::atomic<franka::RobotState>can permit users users to communicate a robot's state efficiently between threads. Trivially copyable is a special property required by values stored instd::atomic, but it requires that all copy assignment and constructors for an object and all of its members be defined asdefault. Thefranka::RobotStatestruct is very close to meeting this requirement, all of its members are trivially copyable except forError- which can readily meet the requirement.This PR makes the necessary changes for
std::atomicto hold afranka::RobotState.