feat(find_reference_citations_from_markup) #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves #198 Implements a function to get name-only ReferenceCitations, taking advantage of style i/em tags on HTML sources - Refactors ReferenceCitation.is_valid_name to utils.is_valid_name - add tests for the new function
grossir
force-pushed
the
198-find-name-only-reference-citations
branch
from
81b4fa2 to
2e6ae84
Compare
grossir
force-pushed
the
198-find-name-only-reference-citations
branch
from
2e6ae84 to
24d6166
Compare
grossir
force-pushed
the
198-find-name-only-reference-citations
branch
from
24d6166 to
d8eb198
Compare
grossir
added a commit
to freelawproject/courtlistener
that referenced
this pull request
Feb 6, 2025
…w uses find_reference_citations_from_markup Adds logic to use freelawproject/eyecite#203
apply refactor from code review #206
…ent pincites This will help disambiguate adyacent ReferenceCitations - add `helpers.add_pre_citation` - add regex needed - add test_FindTest where this is used - resolved a bug in match_on_tokens where MAX_MATCH_CHARS was used incorrectly - updated tests that where invalidated, where what was identified as a Reference was actually a part of the FullCaseCitation
This is passed to `extract_reference_citations`, which allows us to use `find_reference_citations_from_markup` inside that function, simplyfing the calls
Solves #209 - add test cases for full case citation with antecedent and no pincite - fix span calculation on add_pre_citation
grossir
force-pushed
the
198-find-name-only-reference-citations
branch
2 times, most recently
from
8db0f0a to
71c42c6
Compare
Bill noticed on testing that the HTML extraction on real data was slow; we were using a SpanUpdater for each full citation; code is now refactored to create the SpanUpdaters once, for each Opinion
grossir
force-pushed
the
198-find-name-only-reference-citations
branch
from
71c42c6 to
509c12a
Compare
grossir
force-pushed
the
198-find-name-only-reference-citations
branch
from
38fde4f to
61ddc22
Compare
…to exclude whitespace and punctuation - updates test_AnnotateTest for a single space shift - added xml cleanup to benchmark
…no valid names are found
grossir
force-pushed
the
198-find-name-only-reference-citations
branch
from
45981a7 to
8f72df6
Compare
quevon24
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
It took me some time to understand the changes and the existing code but I think everything looks good, the code is well commented and structured, I tried the tests and there were no problems.
I think it's ready
great job @grossir
The Eyecite Report 👁️Gains and LossesThere were 0 gains and 236 losses. Click here to see details.
Time Chart
Generated Files |
|
This looks great. Cant wait to rerun the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #198
Solves problems made evident by first iteration of this PR and described here in #209
find.get_citationsregexes.PRE_FULL_CITATION_REGEXto account for single-name full case citations and for single-name-and-pincite-full-case-citations