-
Notifications
You must be signed in to change notification settings - Fork 22
[v2] ui: Show key + strings ordering #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey, this is really great. Thanks for getting the ball rolling here again and for the extra features. A few things:
Some extras, not required :)
Otherwise yeah I'd say the only real blocker is the global helper and this is some very welcome work! |
b0806a1
to
1de0533
Compare
95bbb2b
to
47e2a13
Compare
@gadicc I skipped
But otherwise, I think this is complete. |
gadicc
added a commit
that referenced
this pull request
Jan 11, 2016
[v2] ui: Show key + strings ordering
gadicc
added a commit
that referenced
this pull request
Jan 11, 2016
Legend! Thanks for all the awesome work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cherry-picked @tomitrescak's commit from his PR (#133) so that it would be mergeable, thanks!
Added a few things so that it can be sorted ascending or descending + insensitively.