feat(no-undefined-types): checking inline tags
#1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
commented
May 5, 2023
kraenhansen
commented
May 5, 2023
brettz9
reviewed
May 6, 2023
brettz9
reviewed
May 6, 2023
brettz9
reviewed
May 6, 2023
brettz9
reviewed
May 6, 2023
|
FWIW, @kraenhansen , I've submitted #1065 to allow disabling reporting (so as to just use the marking of unused variables) as well as to disable marking of variables used (so as to just get reporting of undefined types). |
kraenhansen
commented
May 8, 2023
kraenhansen
commented
May 8, 2023
kraenhansen
force-pushed
the
no-undefined-types-in-inline-links
branch
from
ac9589c to
61a1049
Compare
|
@brettz9 I've rebased on the latest |
|
🎉 This PR is included in version 44.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Reading the docs, I realise that the "namepath-or-url-referencing" value is now missing from: https://github.com/gajus/eslint-plugin-jsdoc/blob/main/docs/settings.md#structuredtags |
|
Ok, thanks, I have a PR to come shortly. |
|
Merged now as part of misc. items in #1087 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it doesn't add a new / separate rule like #1058 aims to, this does solve the underlying need communicated in #858 by updating the
no-undefined-typesrule to incorporate the recently added feature from jsdoccomment of parsing inline tags. Since it already marks types from other tags as used, this seem like a valuable addition until this is refactored into a separate rule or setting onno-undefined-types.