This repository was archived by the owner on May 15, 2025. It is now read-only.
galasactl can launch tests on old service without a submission id being set. #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng set. Signed-off-by: Mike Cobbett <[email protected]>
eamansour
approved these changes
Mar 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mike Cobbett [email protected]
Why ?
Try running the latest galasactl against a system which doesn't set the submission id, or return it in the response payload to the launch request over REST.
It panics with a null pointer exception. Because the submission ID wasn't set.
Added an 'if' so that it's more tolerant. This would be the case if someone uses the galasactl tool to launch tests on an older non-0.40.0 system.