Skip to content

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 2, 2025

🦟 Bug fix

Fixes #1174 and #1159

Summary

I verified locally that the ogre2 engine was able to successfully generate images on mac when running the INTEGRATION_heightmap test. The test failed because when comparing the colors between an image generated by a regular camera and the color component of the point cloud data generated by a depth camera, one particular pixel has a higher error than the current allowed tolerance. Fixed by increasing this error tol from 9 -> 10.

These are the images generated:

Regular RGB image:

Original

Point cloud RGB data:

DepthRgbData

To run the heightmap test on mac:

GZ_ENGINE_TO_TEST=ogre2 GZ_ENGINE_BACKEND=metal ./build/gz-rendering/bin/INTEGRATION_heightmap

The error about unable to find metal_stdlib in the ogre2.log (mentioned in #1159) seems to be unrelated as I see this when launching gz sim with other worlds too, e.g. shapes.sdf. It could be a different issue.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Oct 2, 2025
@iche033 iche033 changed the base branch from gz-rendering10 to main October 2, 2025 00:32
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Oct 7, 2025
@azeey azeey merged commit 7900fc1 into main Oct 7, 2025
13 checks passed
@azeey azeey deleted the iche033/heightmap_test_metal branch October 7, 2025 02:19
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Oct 7, 2025
@scpeters
Copy link
Member

scpeters commented Oct 7, 2025

https://github.com/Mergifyio backport gz-rendering10 gz-rendering9

Copy link
Contributor

mergify bot commented Oct 7, 2025

backport gz-rendering10 gz-rendering9

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 7, 2025
Signed-off-by: Ian Chen <[email protected]>
(cherry picked from commit 7900fc1)
mergify bot pushed a commit that referenced this pull request Oct 7, 2025
Signed-off-by: Ian Chen <[email protected]>
(cherry picked from commit 7900fc1)
iche033 added a commit that referenced this pull request Oct 7, 2025
Signed-off-by: Ian Chen <[email protected]>
(cherry picked from commit 7900fc1)
iche033 added a commit that referenced this pull request Oct 7, 2025
Signed-off-by: Ian Chen <[email protected]>
(cherry picked from commit 7900fc1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪵 jetty Gazebo Jetty
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🧑‍🌾 HeightmapTest.Heightmap test failing in macOS arm64
3 participants