Fix ogre2 heightmap test on metal #1179
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #1174 and #1159
Summary
I verified locally that the ogre2 engine was able to successfully generate images on mac when running the
INTEGRATION_heightmap
test. The test failed because when comparing the colors between an image generated by a regular camera and the color component of the point cloud data generated by a depth camera, one particular pixel has a higher error than the current allowed tolerance. Fixed by increasing this error tol from9
->10
.These are the images generated:
Regular RGB image:
Point cloud RGB data:
To run the heightmap test on mac:
The error about unable to find
metal_stdlib
in the ogre2.log (mentioned in #1159) seems to be unrelated as I see this when launching gz sim with other worlds too, e.g. shapes.sdf. It could be a different issue.Checklist
codecheck
passed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
andGenerated-by
messages.