Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 7, 2025

🦟 Bug fix

Fixes #1174 and #1159

Summary

I verified locally that the ogre2 engine was able to successfully generate images on mac when running the INTEGRATION_heightmap test. The test failed because when comparing the colors between an image generated by a regular camera and the color component of the point cloud data generated by a depth camera, one particular pixel has a higher error than the current allowed tolerance. Fixed by increasing this error tol from 9 -> 10.

These are the images generated:

Regular RGB image:

Original

Point cloud RGB data:

DepthRgbData

To run the heightmap test on mac:

GZ_ENGINE_TO_TEST=ogre2 GZ_ENGINE_BACKEND=metal ./build/gz-rendering/bin/INTEGRATION_heightmap

The error about unable to find metal_stdlib in the ogre2.log (mentioned in #1159) seems to be unrelated as I see this when launching gz sim with other worlds too, e.g. shapes.sdf. It could be a different issue.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #1179 done by [Mergify](https://mergify.com).

Signed-off-by: Ian Chen <[email protected]>
(cherry picked from commit 7900fc1)
@mergify mergify bot requested a review from iche033 as a code owner October 7, 2025 15:28
@mergify mergify bot mentioned this pull request Oct 7, 2025
9 tasks
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Oct 7, 2025
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Oct 7, 2025
@iche033 iche033 merged commit a8086d0 into gz-rendering10 Oct 7, 2025
15 checks passed
@iche033 iche033 deleted the mergify/bp/gz-rendering10/pr-1179 branch October 7, 2025 16:57
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪵 jetty Gazebo Jetty
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🧑‍🌾 HeightmapTest.Heightmap test failing in macOS arm64
1 participant