Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 5, 2025

🦟 Bug fix

Fixes #3058

Summary

When attempting to set the debug visualization mode, the code now checks if giis enabled. If gi is disabled, it logs an error and always sets the debug visualization mode to None to avoid a crash.
Setting a debug visualization mode while gi is disabled can cause a crash due to invalid or released resources. This change ensures safety by forcing the mode to None when gi is not active.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3059 done by [Mergify](https://mergify.com).

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Sep 8, 2025
@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.00%. Comparing base (b682e0a) to head (586888d).
⚠️ Report is 7 commits behind head on gz-sim8.

Additional details and impacted files
@@           Coverage Diff            @@
##           gz-sim8    #3073   +/-   ##
========================================
  Coverage    68.99%   69.00%           
========================================
  Files          342      342           
  Lines        33432    33432           
========================================
+ Hits         23068    23071    +3     
+ Misses       10364    10361    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@iche033 iche033 merged commit 071dec4 into gz-sim8 Sep 9, 2025
10 of 11 checks passed
@iche033 iche033 deleted the mergify/bp/gz-sim8/pr-3059 branch September 9, 2025 00:36
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants