-
Notifications
You must be signed in to change notification settings - Fork 342
Disable failing test on macOS in EntityComponentManager_TEST #3113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
iche033
approved these changes
Oct 15, 2025
|
@Mergifyio backport main gz-sim9 gz-sim8 ign-gazebo6 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit 0f2210f)
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit 0f2210f)
9 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit 0f2210f)
This was referenced Oct 16, 2025
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit 0f2210f) # Conflicts: # src/EntityComponentManager_TEST.cc
9 tasks
azeey
added a commit
that referenced
this pull request
Oct 16, 2025
Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit 0f2210f)
azeey
added a commit
that referenced
this pull request
Oct 16, 2025
Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit 0f2210f)
azeey
added a commit
that referenced
this pull request
Oct 17, 2025
Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit 0f2210f)
azeey
added a commit
that referenced
this pull request
Oct 17, 2025
Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit 0f2210f)
azeey
added a commit
that referenced
this pull request
Oct 17, 2025
Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit 0f2210f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Part of #3089
Summary
This tests have been failing on macOS consistently. I have been able to reproduce the failures locally, but I have not been able to understand why they are failing. Let's disable them for now to unblock other PRs.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.