Skip to content

Conversation

XINJIANGMO
Copy link
Contributor

🦟 Bug fix

Fixes #3117

Summary

change parent property to ApplicationWindow.overlay(previous usage in former gz-sim version) or simply overlay

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)

Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, this seems to work as expected. Thanks for the fix!!

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Oct 16, 2025
@arjo129 arjo129 enabled auto-merge (squash) October 16, 2025 11:53
@arjo129
Copy link
Contributor

arjo129 commented Oct 16, 2025

P.S. I recommend targeting main now that jetty is out. We need to remember to forward port this fix once its merged.

@arjo129
Copy link
Contributor

arjo129 commented Oct 23, 2025

@Mergifyio backport main

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2025

backport main

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Help button in Joint Position Controller can not pop up help text

4 participants