Fix thread issue by adding check for invalid CLI combo #3135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #3132
Summary
In the previous flow, the GUI thread (which spawns a separate GUI subprocess) starts before
createServerConfigruns. So whengz.ccprints the error, the GUI is already launched;returningor callingstd::exitingz.ccwon’t stop the GUI subprocess started viastd::system.This order also causes the crash:
mainexits while the GUIstd::threadremains joinable, its destructor callsstd::terminate, resulting interminate called without an active exception.This fix adds a check for this invalid combo in
sim_main.ccto avoid thread issue.Checklist
codecheckpassed (See contributing)