Skip to content

Conversation

bastianhjaeger
Copy link

🦟 Bug fix

Fixes missing toElement() function in NavSat and the referring else if in the generic Sensor function

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey
Copy link
Collaborator

azeey commented Aug 1, 2025

Hi @bastianhjaeger, what's the status of this PR? The code to add ToElement looks good, but making NavSat on actors work might need more work in gz-sim.

@azeey
Copy link
Collaborator

azeey commented Aug 6, 2025

Thanks for the contribution, but since there hasn't been any updates for a while, I'll remove it from the Jetty milestone. But please don't let this stop you from pushing on this PR. Once the initial feature freeze window is over, we'll be able to merge this.

@azeey azeey removed this from the Jetty Release milestone Aug 6, 2025
@azeey azeey mentioned this pull request Sep 2, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

2 participants