-
Notifications
You must be signed in to change notification settings - Fork 46
Change the logic to save the code status leaving the user the ability to set the command #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,8 +18,7 @@ BSD-3-Clause license. --> | |
| <param name="port_prefix">/yarp-robot-logger</param> | ||
| <param name="log_text">true</param> | ||
| <param name="text_logging_subnames">("ergocub-torso/yarprobotinterface")</param> | ||
| <param name="log_code_status">true</param> | ||
| <param name="code_status_cmd_prefixes">("ssh [email protected]" "ssh [email protected]")</param> | ||
| <param name="code_status_cmds">("ssh [email protected] 'bash ${ROBOTOLOGY_SUPERBUILD_SOURCE_DIR}/scripts/robotologyGitStatus.sh' > {filename}_robotology_10_0_2_2.txt" "ssh [email protected] 'apt list --installed' > {filename}_apt_10_0_2_2.txt" "ssh [email protected] 'bash ${ROBOTOLOGY_SUPERBUILD_SOURCE_DIR}/scripts/robotologyGitStatus.sh' > {filename}_robotology_10_0_2_3.txt" "ssh [email protected] 'apt list --installed' > {filename}_apt_10_0_2_3.txt")</param> | ||
| <param name="log_cameras">true</param> | ||
| <param name="log_frames">false</param> | ||
| <param name="log_robot_data">true</param> | ||
|
|
||
13 changes: 0 additions & 13 deletions
13
...erDevice/app/robots/ergoCubSN000_spu01/blf-yarp-robot-logger-interfaces/all_joints_mc.xml
This file was deleted.
Oops, something went wrong.
35 changes: 0 additions & 35 deletions
35
...oggerDevice/app/robots/ergoCubSN000_spu01/blf-yarp-robot-logger-interfaces/ft_clients.xml
This file was deleted.
Oops, something went wrong.
65 changes: 0 additions & 65 deletions
65
...ggerDevice/app/robots/ergoCubSN000_spu01/blf-yarp-robot-logger-interfaces/imu_clients.xml
This file was deleted.
Oops, something went wrong.
45 changes: 0 additions & 45 deletions
45
...gerDevice/app/robots/ergoCubSN000_spu01/blf-yarp-robot-logger-interfaces/mas-remapper.xml
This file was deleted.
Oops, something went wrong.
34 changes: 0 additions & 34 deletions
34
...otLoggerDevice/app/robots/ergoCubSN000_spu01/blf-yarp-robot-logger-interfaces/webcams.xml
This file was deleted.
Oops, something went wrong.
44 changes: 0 additions & 44 deletions
44
...rDevice/app/robots/ergoCubSN000_spu01/blf-yarp-robot-logger-interfaces/wrench_clients.xml
This file was deleted.
Oops, something went wrong.
19 changes: 0 additions & 19 deletions
19
devices/YarpRobotLoggerDevice/app/robots/ergoCubSN000_spu01/launch-yarp-robot-logger.xml
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this flag has been removed by mistake since the code to read it is still there. In general, I would prefer to keep it anyhow to facilitate the enabling/disabling of this functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes my fault! Let me add it again !