feat: Add auto-start logging feature and refactor device state management#1036
Open
GiulioRomualdi wants to merge 5 commits intomasterfrom
Open
feat: Add auto-start logging feature and refactor device state management#1036GiulioRomualdi wants to merge 5 commits intomasterfrom
GiulioRomualdi wants to merge 5 commits intomasterfrom
Conversation
…ment - Introduced `auto_start_logging` parameter in configuration files to enable automatic logging on device startup. - Implemented a state machine in `YarpRobotLoggerDevice` to manage device states: Idle, Recording, and Saving. - Added new RPC commands: `startRecording`, `saveRecording`, `saveAndStopRecording`, and `discardRecording` to control the logging process. - Refactored existing methods to accommodate state transitions and ensure proper resource management during recording sessions. - Updated documentation in the Thrift service definition to reflect new commands and their functionalities.
Collaborator
Author
|
Needs to be properly tested on the robot |
Collaborator
Author
|
This substitues #1034 |
Collaborator
Author
|
This requires robotology/robometry#201 |
Collaborator
I would suggest to increase the required version number then, to avoid obscure compilation errors |
Collaborator
Author
|
I tried to update the pixi.lock but I have the following error related to conda-forge/librobometry-feedstock#51 |
Collaborator
Author
|
Pixi now fails with this error. I was actually thinking to disable the test of ros2 from the CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auto_start_loggingparameter in configuration files to enable automatic logging on device startup.YarpRobotLoggerDeviceto manage device states: Idle, Recording, and Saving.startRecording,saveRecording,saveAndStopRecording, anddiscardRecordingto control the logging process.