Skip to content

fix(release): publish sharpebench-edge before sharpebench-wasm#9

Merged
ReverseZoom2151 merged 1 commit into
mainfrom
fix/release-loop-order
Jun 27, 2026
Merged

fix(release): publish sharpebench-edge before sharpebench-wasm#9
ReverseZoom2151 merged 1 commit into
mainfrom
fix/release-loop-order

Conversation

@ReverseZoom2151

@ReverseZoom2151 ReverseZoom2151 commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

v0.0.10 made sharpebench-wasm depend on sharpebench-edge, but the publish loop listed wasm before edge, so wasm@0.0.10 couldn't resolve edge@0.0.10. Reorder edge ahead of wasm. Idempotent loop completes the 4 crates the first run missed (edge/wasm/harness/sharpebench); the 6 already at 0.0.10 are skipped on re-run.

Summary by CodeRabbit

  • Chores
    • Updated the release publishing order for crates, moving sharpebench-edge earlier in the sequence.
    • Reformatted the publish list for readability while keeping the same set of crates included.

v0.0.10 wired sharpebench-edge into sharpebench-wasm, but the publish loop still listed
wasm before edge, so wasm@0.0.10 failed to resolve edge@0.0.10 (not yet published). Move
edge ahead of wasm. The loop is idempotent, so re-running completes the 4 crates that the
first v0.0.10 run did not reach (edge, wasm, harness, sharpebench); the 6 already at 0.0.10
are skipped.
@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

In the release workflow's crate publishing loop, sharpebench-edge is moved earlier in the iteration order to appear immediately after sharpebench-stats, with the loop reformatted across multiple lines and the inline comment updated.

Changes

Release Workflow Crate Publish Order

Layer / File(s) Summary
Crate publish order fix
.github/workflows/release.yml
sharpebench-edge is moved earlier in the for c in ... loop (right after sharpebench-stats), and the loop is reformatted across multiple lines with an updated comment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A crate out of order caused quite a fuss,
Edge goes after stats — no more needless muss!
The loop is reformatted, the comment corrected,
Dependency order is now well-respected.
Hooray for the fix, says the bunny with glee! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately captures the release-order fix by placing sharpebench-edge before sharpebench-wasm.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-loop-order

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/release.yml:
- Around line 91-95: The release fallback publish flow is out of sync with the
documented package order because scripts/publish.sh still omits
sharpebench-stats and sharpebench-edge, which can break sharpebench-wasm
publishing. Update scripts/publish.sh to use the same package order as the
release workflow (including sharpebench-stats and sharpebench-edge before
sharpebench-wasm) or remove scripts/publish.sh as a supported release path if it
should no longer be used.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aca81a72-26c2-492c-9dca-1ac4b63ebf90

📥 Commits

Reviewing files that changed from the base of the PR and between 9e35bdd and bd893a0.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Comment on lines +91 to +95
# harness on sim; sharpebench on all). edge depends on stats and is itself a dep of
# wasm + the CLI, so it MUST come before wasm. publish=false members are omitted.
for c in sharpebench-stats sharpebench-edge sharpebench-core sharpebench-protocol \
sharpebench-attest sharpebench-sim sharpebench-leaderboard sharpebench-wasm \
sharpebench-harness sharpebench; do

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== release workflow crate order =="
sed -n '84,105p' .github/workflows/release.yml

echo
echo "== publish script crate order =="
sed -n '1,80p' scripts/publish.sh

echo
echo "== references to scripts/publish.sh =="
rg -n 'scripts/publish\.sh|publish\.sh' . github .github docs README.md

Repository: general-liquidity/sharpebench

Length of output: 3847


Keep scripts/publish.sh aligned with the release order scripts/publish.sh still skips sharpebench-stats and sharpebench-edge, so the documented fallback publish flow can break on sharpebench-wasm. Update the script in this PR or remove it as a supported path.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/release.yml around lines 91 - 95, The release fallback
publish flow is out of sync with the documented package order because
scripts/publish.sh still omits sharpebench-stats and sharpebench-edge, which can
break sharpebench-wasm publishing. Update scripts/publish.sh to use the same
package order as the release workflow (including sharpebench-stats and
sharpebench-edge before sharpebench-wasm) or remove scripts/publish.sh as a
supported release path if it should no longer be used.

@ReverseZoom2151 ReverseZoom2151 merged commit 137fef2 into main Jun 27, 2026
7 checks passed
@ReverseZoom2151 ReverseZoom2151 deleted the fix/release-loop-order branch June 27, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant