Skip to content

fix(release): publish sharpebench-edge before sharpebench-wasm #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReverseZoom2151 merged 1 commit into from
Jun 27, 2026
Merged

fix(release): publish sharpebench-edge before sharpebench-wasm #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,11 @@ jobs:
UA="sharpebench-release (general-liquidity)" # crates.io rejects requests without a User-Agent
V="$(grep -m1 '^version' Cargo.toml | sed 's/.*"\(.*\)".*/\1/')"
# leaves first → CLI last (sim/leaderboard/wasm depend on core/protocol/attest;
# harness on sim; sharpebench on all). publish=false members are simply omitted.
for c in sharpebench-stats sharpebench-core sharpebench-protocol sharpebench-attest \
sharpebench-sim sharpebench-leaderboard sharpebench-wasm \
sharpebench-harness sharpebench-edge sharpebench; do
# harness on sim; sharpebench on all). edge depends on stats and is itself a dep of
# wasm + the CLI, so it MUST come before wasm. publish=false members are omitted.
for c in sharpebench-stats sharpebench-edge sharpebench-core sharpebench-protocol \
sharpebench-attest sharpebench-sim sharpebench-leaderboard sharpebench-wasm \
sharpebench-harness sharpebench; do
Comment on lines +91 to +95

@coderabbitai coderabbitai Bot Jun 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== release workflow crate order =="
sed -n '84,105p' .github/workflows/release.yml

echo
echo "== publish script crate order =="
sed -n '1,80p' scripts/publish.sh

echo
echo "== references to scripts/publish.sh =="
rg -n 'scripts/publish\.sh|publish\.sh' . github .github docs README.md

Repository: general-liquidity/sharpebench

Length of output: 3847

Keep scripts/publish.sh aligned with the release order scripts/publish.sh still skips sharpebench-stats and sharpebench-edge, so the documented fallback publish flow can break on sharpebench-wasm. Update the script in this PR or remove it as a supported path.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/release.yml around lines 91 - 95, The release fallback
publish flow is out of sync with the documented package order because
scripts/publish.sh still omits sharpebench-stats and sharpebench-edge, which can
break sharpebench-wasm publishing. Update scripts/publish.sh to use the same
package order as the release workflow (including sharpebench-stats and
sharpebench-edge before sharpebench-wasm) or remove scripts/publish.sh as a
supported release path if it should no longer be used.

if curl -s -A "$UA" "https://crates.io/api/v1/crates/$c/$V" | grep -q "\"num\":\"$V\""; then
echo "✓ $c@$V already on crates.io — skipping"
else
Expand Down